Skip to content

nit(ci): remove a trailing space from daily-tests.yml #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2024
Merged

nit(ci): remove a trailing space from daily-tests.yml #2098

merged 1 commit into from
Aug 29, 2024

Conversation

brody4hire
Copy link
Contributor

@brody4hire brody4hire commented Aug 29, 2024 •
edited
Loading

TODO

  • I would like to raise an issue to start linting non-source files such as Cargo & GitHub CI files in CI ✅ - raised lint markdown, spelling, etc. in GitHub CI #2099 to track this
  • I would love to contribute a solution for this CI improvement, cannot promise when I may have time for this ❌ deferred for now

I don't want to block merging this, thinking we should improve the automation in this area (if possible & anyone has time to deal with this)

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (a2fedec) to head (097e5f2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2098   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files         102      102           
  Lines       23514    23514           
=======================================
  Hits        22283    22283           
  Misses       1231     1231

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brody4hire brody4hire mentioned this pull request Aug 29, 2024
Open
1 task
cpu
cpu approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does a PR removing a single character need to be a draft? 🤪

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Aug 29, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3971842 3997782 25940 (0.65%) 3.70%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5088497 5117573 29076 (0.57%) 3.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8885691 8909111 23420 (0.26%) 0.95%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13833477 13855096 21619 (0.16%) 0.96%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13822929 13843886 20957 (0.15%) 0.89%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46440390 46388472 -51918 (-0.11%) 0.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8880321 8888487 8166 (0.09%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30714874 30743051 28177 (0.09%) 0.27%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46392790 46427036 34246 (0.07%) 0.32%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31135101 31157866 22765 (0.07%) 0.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31143682 31121433 -22249 (-0.07%) 0.46%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34799355 34783341 -16014 (-0.05%) 0.62%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34739536 34726070 -13466 (-0.04%) 0.44%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714652 92680777 -33875 (-0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80606182 80577483 -28699 (-0.04%) 0.22%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13430761 13434964 4203 (0.03%) 1.09%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58213655 58230025 16370 (0.03%) 0.23%
handshake_tickets_ring_1.2_rsa_aes_server 4705010 4704102 -908 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1916775 1916471 -304 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3381620 3381090 -530 (-0.02%) 0.23%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3916385 3915822 -563 (-0.01%) 0.38%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4443267 4442689 -578 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2228355 2228066 -289 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43965156 43959475 -5681 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32981997 32978766 -3231 (-0.01%) 0.80%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4390078 4389656 -422 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30715742 30718680 2938 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2016931 2016753 -178 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4267126 4267477 351 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32935624 32938324 2700 (0.01%) 0.55%
handshake_no_resume_ring_1.3_rsa_chacha_client 2957463 2957230 -233 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4026287 4026592 305 (0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4283938 4283617 -321 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2853540 2853747 207 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31122084 31120071 -2013 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42412600 42415275 2675 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41959649 41962288 2639 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2951447 2951271 -176 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42356497 42358306 1809 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3914855 3914701 -154 (-0.00%) 0.45%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32962535 32961270 -1265 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42346550 42344983 -1567 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30733347 30734325 978 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43366511 43367866 1355 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42423111 42424382 1271 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30758438 30759306 868 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34787950 34787054 -896 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31193511 31192722 -789 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13741892 13742219 327 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2134210 2134160 -50 (-0.00%) 0.79%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92702312 92704460 2148 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557004 4556908 -96 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43464861 43463953 -908 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30709517 30710128 611 (0.00%) 0.36%
handshake_no_resume_ring_1.3_rsa_aes_server 12180218 12179985 -233 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13744436 13744178 -258 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2136320 2136280 -40 (-0.00%) 0.77%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44045965 44045192 -773 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34788526 34789133 607 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46428223 46429022 799 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41974839 41975542 703 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43460569 43461294 725 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2235491 2235454 -37 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34768623 34769196 573 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41957228 41957896 668 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43370781 43370118 -663 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30741071 30741540 469 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4393160 4393227 67 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31171613 31171145 -468 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41884894 41885445 551 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35476131 35475707 -424 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80507104 80508050 946 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31145165 31145511 346 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42340170 42340612 442 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42406136 42406519 383 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473590 35473277 -313 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46353070 46352667 -403 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44039693 44039323 -370 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46439253 46438872 -381 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58328316 58328787 471 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32962439 32962175 -264 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12185933 12185837 -96 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44037366 44037025 -341 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1919647 1919634 -13 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58247434 58247763 329 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46427409 46427150 -259 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58209137 58208841 -296 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58332041 58331747 -294 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46446944 46447176 232 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43959995 43960213 218 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92663355 92663776 421 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41875846 41876035 189 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3381890 3381905 15 (0.00%) 0.26%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92660036 92660374 338 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33003547 33003431 -116 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11991877 11991919 42 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43363919 43363768 -151 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80515554 80515831 277 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34767938 34768054 116 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33002473 33002572 99 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80504184 80504424 240 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41893967 41894090 123 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80607939 80608158 219 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46435624 46435733 109 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43463843 43463942 99 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68666070 68666206 136 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43957599 43957683 84 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58331274 58331168 -106 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58244781 58244833 52 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80606601 80606672 71 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92664654 92664728 74 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92705045 92705109 64 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.47 ms -0.04 ms (-0.85%) 5.62%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.45 ms 5.41 ms -0.04 ms (-0.76%) 5.11%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.45 ms 5.41 ms -0.04 ms (-0.70%) 4.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.19 ms -0.03 ms (-0.66%) 5.16%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.30 ms -0.04 ms (-0.65%) 3.91%
transfer_no_resume_ring_1.2_rsa_aes 6.74 ms 6.70 ms -0.04 ms (-0.64%) 3.86%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 483.38 µs 480.43 µs -2.95 µs (-0.61%) 2.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 484.15 µs 481.34 µs -2.81 µs (-0.58%) 3.18%
transfer_no_resume_ring_1.3_rsa_aes 6.82 ms 6.78 ms -0.03 ms (-0.45%) 3.87%
handshake_no_resume_ring_1.3_ecdsap256_chacha 506.90 µs 505.05 µs -1.85 µs (-0.36%) 2.99%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.43 ms 9.40 ms -0.03 ms (-0.36%) 2.69%
handshake_no_resume_ring_1.3_ecdsap256_aes 509.43 µs 507.63 µs -1.80 µs (-0.35%) 3.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.97 ms 12.93 ms -0.04 ms (-0.30%) 1.92%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.98 ms 12.94 ms -0.04 ms (-0.28%) 1.87%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.91 ms 13.88 ms -0.03 ms (-0.24%) 1.93%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms -0.00 ms (-0.23%) 4.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.69 ms 13.66 ms -0.03 ms (-0.23%) 1.74%
transfer_no_resume_ring_1.3_rsa_chacha 13.46 ms 13.43 ms -0.03 ms (-0.22%) 2.22%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.07 ms 16.04 ms -0.03 ms (-0.21%) 1.41%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.08 ms 2.07 ms -0.00 ms (-0.21%) 2.61%
handshake_no_resume_ring_1.3_rsa_chacha 991.83 µs 989.75 µs -2.08 µs (-0.21%) 1.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms -0.00 ms (-0.17%) 1.02%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.60 ms -0.01 ms (-0.17%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.40 ms -0.00 ms (-0.17%) 4.66%
handshake_no_resume_ring_1.2_rsa_aes 978.92 µs 977.41 µs -1.50 µs (-0.15%) 1.57%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.49 ms 5.50 ms 0.01 ms (0.15%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.42 ms 1.41 ms -0.00 ms (-0.14%) 3.88%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.20 ms -0.00 ms (-0.13%) 1.34%
handshake_session_id_ring_1.3_ecdsap384_aes 9.80 ms 9.79 ms -0.01 ms (-0.12%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.32 ms 6.33 ms 0.01 ms (0.11%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.08 ms 6.09 ms 0.01 ms (0.10%) 1.17%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.34 ms 6.35 ms 0.01 ms (0.09%) 1.15%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.28 ms 2.28 ms -0.00 ms (-0.08%) 1.95%
handshake_tickets_ring_1.2_rsa_aes 1.65 ms 1.65 ms 0.00 ms (0.07%) 1.91%
handshake_tickets_ring_1.3_ecdsap384_aes 9.86 ms 9.85 ms -0.01 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.20 ms 7.20 ms -0.00 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.82 ms 9.81 ms -0.01 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.25 ms 7.25 ms -0.00 ms (-0.07%) 1.12%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.21 ms 6.21 ms 0.00 ms (0.06%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.16 ms 7.16 ms -0.00 ms (-0.06%) 1.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.38 ms 5.38 ms 0.00 ms (0.06%) 1.20%
handshake_no_resume_ring_1.3_rsa_aes 990.67 µs 990.13 µs -0.53 µs (-0.05%) 1.73%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.45 ms 6.45 ms 0.00 ms (0.05%) 1.07%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.77 ms 9.77 ms -0.01 ms (-0.05%) 1.04%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.45 ms 6.45 ms 0.00 ms (0.05%) 1.46%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.00 ms (-0.05%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.50 ms 5.50 ms 0.00 ms (0.05%) 1.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.39 ms 5.39 ms 0.00 ms (0.03%) 1.72%
handshake_session_id_ring_1.3_ecdsap256_aes 6.72 ms 6.71 ms -0.00 ms (-0.03%) 1.11%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.22 ms 6.22 ms 0.00 ms (0.02%) 1.30%
handshake_tickets_ring_1.3_ecdsap256_aes 6.77 ms 6.77 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.57 ms -0.00 ms (-0.01%) 1.11%
handshake_tickets_ring_1.3_rsa_chacha 7.21 ms 7.21 ms 0.00 ms (0.01%) 1.21%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.10 ms 6.10 ms 0.00 ms (0.01%) 1.47%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.68 ms 6.68 ms 0.00 ms (0.00%) 1.03%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.73 ms 6.73 ms -0.00 ms (-0.00%) 1.19%

Additional information

Historical results

Checkout details:

@brody4hire brody4hire marked this pull request as ready for review August 29, 2024 15:22
@brody4hire
Copy link
Contributor Author

My apologies ... now ready for review ... already raised issue #2099 to go after the root cause 😄😄

@djc
Copy link
Member

djc commented Aug 29, 2024

Please rebase to get rid of the merge commit.

@brody4hire brody4hire force-pushed the remove-trailing-whitespace-from-ci-daily-tests-yml branch from e784e31 to 22c92bd Compare August 29, 2024 20:11
@brody4hire
Copy link
Contributor Author

rebased thanks!

@brody4hire brody4hire changed the title nit(ci): remove trailing whitespace from daily-tests.yml nit(ci): remove trailing space from daily-tests.yml Aug 29, 2024
@brody4hire brody4hire marked this pull request as draft August 29, 2024 20:19
@brody4hire
Copy link
Contributor Author

Looks like there was a fuzz issue in CI: https://github.com/rustls/rustls/actions/runs/10621951781/job/29445121683?pr=2098

I have actually updated the title, will try another force-push to update the title in the commit message & see if this fuzz issue persists or goes away.

@brody4hire brody4hire changed the title nit(ci): remove trailing space from daily-tests.yml nit(ci): remove a trailing space from daily-tests.yml Aug 29, 2024
@brody4hire brody4hire force-pushed the remove-trailing-whitespace-from-ci-daily-tests-yml branch from 22c92bd to 097e5f2 Compare August 29, 2024 20:22
@brody4hire brody4hire marked this pull request as ready for review August 29, 2024 20:33
@ctz ctz added this pull request to the merge queue Aug 29, 2024
Merged via the queue into rustls:main with commit 94db910 Aug 29, 2024
25 checks passed
@brody4hire brody4hire deleted the remove-trailing-whitespace-from-ci-daily-tests-yml branch August 29, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brody4hire @djc @cpu @ctz