Skip to content

Ensure only max_early_data_size will be read after reading from ReadEarlyData #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2024
Merged

Ensure only max_early_data_size will be read after reading from ReadEarlyData #2097

merged 2 commits into from
Aug 29, 2024

Conversation

tahmid-23
Copy link
Contributor

@tahmid-23 tahmid-23 commented Aug 28, 2024 •
edited
Loading

I'm not sure how to write a test for this
resolves #2096

@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.76%. Comparing base (cc40342) to head (42b80f2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/server/server_conn.rs 70.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2097      +/-   ##
==========================================
- Coverage   94.78%   94.76%   -0.02%     
==========================================
  Files         102      102              
  Lines       23497    23514      +17     
==========================================
+ Hits        22271    22283      +12     
- Misses       1226     1231       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ctz
ctz approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me. I will look into what the options are for testing this.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Aug 28, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1912010 1916451 ⚠️ 4441 (0.23%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8916387 8880328 -36059 (-0.40%) 1.29%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5148663 5166703 18040 (0.35%) 4.40%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32926520 33010459 83939 (0.25%) 0.76%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13805430 13836328 30898 (0.22%) 0.84%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2140486 2136614 -3872 (-0.18%) 0.76%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 33002223 32946682 -55541 (-0.17%) 0.68%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8900968 8886030 -14938 (-0.17%) 0.79%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30701468 30750878 49410 (0.16%) 0.33%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3920389 3914408 -5981 (-0.15%) 0.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3376386 3381341 4955 (0.15%) 0.22%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13421582 13403766 -17816 (-0.13%) 1.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31137825 31177975 40150 (0.13%) 0.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31084313 31121852 37539 (0.12%) 0.45%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34691158 34732976 41818 (0.12%) 0.44%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58205350 58255363 50013 (0.09%) 0.23%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46392530 46431787 39257 (0.08%) 0.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30708474 30732691 24217 (0.08%) 0.40%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3381697 3383707 2010 (0.06%) 0.26%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80642686 80602890 -39796 (-0.05%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3914380 3912785 -1595 (-0.04%) 0.44%
transfer_no_resume_ring_1.3_rsa_aes_server 46462764 46446992 -15772 (-0.03%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46368615 46353031 -15584 (-0.03%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46454705 46439601 -15104 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46414671 46399783 -14888 (-0.03%) 0.41%
handshake_session_id_ring_1.2_rsa_aes_server 4266179 4267242 1063 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46450995 46440472 -10523 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2951446 2952089 643 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1919505 1919904 399 (0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557544 4556613 -931 (-0.02%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4284655 4283839 -816 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42409459 42417168 7709 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31127227 31121805 -5422 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2957428 2957889 461 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3983648 3984268 620 (0.02%) 4.93%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43360115 43366369 6254 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44038676 44045002 6326 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58329021 58337339 8318 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43954107 43960170 6063 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30744293 30740335 -3958 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42341740 42347131 5391 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41876019 41881082 5063 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34793562 34797463 3901 (0.01%) 0.63%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4389841 4390264 423 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31172252 31169363 -2889 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34786026 34789247 3221 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46431820 46427871 -3949 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33005896 33003405 -2491 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43954586 43957795 3209 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13852254 13851282 -972 (-0.01%) 0.91%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34771195 34769117 -2078 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12179864 12180501 637 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92672405 92677217 4812 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30718944 30717350 -1594 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32960840 32962430 1590 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2134044 2134146 102 (0.00%) 0.79%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34767061 34768616 1555 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41965753 41963922 -1831 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43466766 43464879 -1887 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4704439 4704235 -204 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2017047 2016960 -87 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43462759 43464581 1822 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2235298 2235390 92 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44038981 44040793 1812 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43365394 43367135 1741 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58248059 58245877 -2182 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43459587 43461193 1606 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2228197 2228117 -80 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43958822 43960344 1522 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2853729 2853824 95 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42405111 42406482 1371 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41875721 41876989 1268 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4025942 4026053 111 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43362515 43363704 1189 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30733525 30734298 773 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12185954 12186237 283 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42358750 42357804 -946 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92663760 92665729 1969 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92705010 92703059 -1951 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34786538 34787258 720 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11991847 11992095 248 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44035865 44036750 885 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32961646 32961068 -578 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33002813 33003373 560 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41957128 41957816 688 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4393596 4393529 -67 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31145753 31146122 369 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13741666 13741827 161 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58331955 58331348 -607 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30758981 30759264 283 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41974181 41974484 303 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42423579 42423299 -280 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80607535 80608045 510 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92661014 92660447 -567 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42340653 42340431 -222 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58327939 58328244 305 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13744420 13744356 -64 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92664780 92664414 -366 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80606634 80606321 -313 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475659 35475796 137 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58208982 58209189 207 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80504076 80503806 -270 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58247725 58247535 -190 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46428587 46428466 -121 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80507485 80507693 208 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31192586 31192658 72 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473739 35473798 59 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4442728 4442722 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68666015 68666083 68 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92705499 92705446 -53 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80515614 80515660 46 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41893620 41893613 -7 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.43 ms 1.40 ms -0.03 ms (-2.07%) 6.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.39 ms 1.36 ms -0.03 ms (-2.01%) 6.06%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.44 ms 1.41 ms -0.03 ms (-1.92%) 5.72%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.11 ms 2.07 ms -0.03 ms (-1.55%) 2.61%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 0.99 ms -0.01 ms (-1.05%) 1.73%
handshake_no_resume_ring_1.3_rsa_chacha 999.86 µs 990.99 µs -8.87 µs (-0.89%) 1.31%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.30 ms 2.28 ms -0.02 ms (-0.87%) 1.85%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.56 ms -0.01 ms (-0.76%) 1.02%
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.65 ms -0.01 ms (-0.74%) 1.78%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.49 ms 6.45 ms -0.03 ms (-0.52%) 1.01%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.36 ms 6.33 ms -0.03 ms (-0.42%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.44 ms 5.42 ms -0.02 ms (-0.39%) 4.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.47 ms 4.48 ms 0.02 ms (0.38%) 6.94%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.20 ms 0.02 ms (0.30%) 6.11%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.52 ms 5.50 ms -0.02 ms (-0.28%) 1.11%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.48 ms 6.46 ms -0.02 ms (-0.28%) 1.53%
handshake_tickets_ring_1.3_rsa_aes 7.28 ms 7.26 ms -0.02 ms (-0.28%) 1.12%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 479.89 µs 481.21 µs 1.31 µs (0.27%) 3.78%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.43 ms 5.42 ms -0.01 ms (-0.27%) 4.57%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.23 ms 6.22 ms -0.02 ms (-0.26%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.38 ms 6.36 ms -0.02 ms (-0.25%) 1.35%
handshake_tickets_ring_1.3_rsa_chacha 7.23 ms 7.22 ms -0.02 ms (-0.24%) 1.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 482.00 µs 483.01 µs 1.02 µs (0.21%) 3.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.40 ms 5.41 ms 0.01 ms (0.20%) 1.65%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.75 ms 6.74 ms -0.01 ms (-0.20%) 1.22%
handshake_no_resume_ring_1.3_ecdsap256_aes 507.76 µs 508.72 µs 0.96 µs (0.19%) 3.61%
handshake_session_id_ring_1.3_rsa_chacha 7.18 ms 7.17 ms -0.01 ms (-0.18%) 1.48%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.11 ms 6.12 ms 0.01 ms (0.16%) 1.45%
handshake_session_id_ring_1.3_rsa_aes 7.23 ms 7.22 ms -0.01 ms (-0.16%) 1.52%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.03 ms 16.06 ms 0.03 ms (0.16%) 1.51%
handshake_no_resume_ring_1.2_rsa_aes 978.71 µs 980.22 µs 1.51 µs (0.15%) 1.48%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.51 ms 5.51 ms 0.01 ms (0.15%) 1.49%
transfer_no_resume_ring_1.3_rsa_aes 6.80 ms 6.79 ms -0.01 ms (-0.13%) 4.34%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.70 ms 6.69 ms -0.01 ms (-0.12%) 1.17%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.22 ms 6.23 ms 0.01 ms (0.12%) 1.24%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.96 ms 0.01 ms (0.12%) 2.08%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.94 ms 12.95 ms 0.01 ms (0.11%) 2.27%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.90 ms 13.88 ms -0.01 ms (-0.11%) 1.97%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.83 ms 9.82 ms -0.01 ms (-0.09%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.79 ms 6.79 ms -0.01 ms (-0.09%) 1.39%
handshake_session_id_ring_1.3_ecdsap256_aes 6.74 ms 6.74 ms -0.01 ms (-0.08%) 1.60%
handshake_no_resume_ring_1.3_ecdsap256_chacha 504.56 µs 504.95 µs 0.39 µs (0.08%) 2.99%
handshake_tickets_ring_1.3_ecdsap384_aes 9.87 ms 9.87 ms -0.01 ms (-0.07%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.07%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.20 ms -0.00 ms (-0.07%) 1.04%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.66 ms 13.67 ms 0.01 ms (0.07%) 1.93%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.06%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.82 ms 9.82 ms 0.01 ms (0.05%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.44 ms 13.44 ms 0.01 ms (0.04%) 2.02%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.78 ms 9.78 ms -0.00 ms (-0.04%) 1.10%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.40 ms 9.40 ms 0.00 ms (0.03%) 2.81%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.10 ms 6.09 ms -0.00 ms (-0.03%) 1.17%
transfer_no_resume_ring_1.2_rsa_aes 6.71 ms 6.71 ms -0.00 ms (-0.03%) 3.51%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.31 ms 6.31 ms -0.00 ms (-0.02%) 4.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.38 ms 5.38 ms -0.00 ms (-0.01%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms 0.00 ms (0.00%) 1.12%

Additional information

Historical results

Checkout details:

djc
djc approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! (Pending test coverage.)

@ctz ctz mentioned this pull request Aug 29, 2024
Closed
@ctz ctz added this pull request to the merge queue Aug 29, 2024
Merged via the queue into rustls:main with commit a2fedec Aug 29, 2024
23 of 24 checks passed
@tahmid-23 tahmid-23 deleted the advisory-fix-1 branch August 29, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client can send more TLS1.3 early data than maximum if early data is read
4 participants
@tahmid-23 @djc @cpu @ctz