ci: cross-target build & test updates #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af86354 to
684e42b
Compare
djc
reviewed
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 102 102
Lines 23514 23514
=======================================
Hits 22283 22283
Misses 1231 1231 ☔ View full report in Codecov by Sentry. |
brody4hire
commented
Aug 28, 2024
a5b14bc to
dc66dad
Compare
|
Shoud be ready now - review comments should be resolved |
djc
approved these changes
Aug 29, 2024
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
cpu
approved these changes
Aug 29, 2024
f882e6b to
cf48253
Compare
|
I just rebased with recent updates from Yes this will definitely take some more CI resources, in the form of more parallel jobs. I did keep what I think are the most important cross targets toward the top of the matrix ... and did add some comments to help people understand what I think is the relative importance of these cross targets. Assuming that we can start adding more and more embedded targets, as discussed in #2100, I would totally favor removing say a couple of the targets I added to reduce the chance of waiting for CI jobs stuck queued. Thanks! |
auto-merge was automatically disabled
August 29, 2024 21:21
Head branch was pushed to by a user without write access
cf48253 to
58dfc6a
Compare
|
Seems to be held up by "Check cross compilation targets" job, which I had renamed in this PR.. |
auto-merge was automatically disabled
August 30, 2024 07:35
Head branch was pushed to by a user without write access
3f30ac0 to
a431772
Compare
|
I have pushed some updates to add a few more targets & keep the same |
|
I have removed the old job name from the merge queue checks. Right now the merge queue is not gating on any of the cross-compilation jobs. Not sure what we want to do with that going forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATED: update to do
cross testover multiple targetsLeaving out the following targets, need to use
portable-atomicto get CA test working for these (already got these working in my personal branch):Another nice target for
no-std, if we can work around issue with no atomic refs for issue #2068:thumbv6m-none-eabiwill likely defer these missing targets for issue #2100 (time permitting, of course)
NOTES - UPDATED:
I think this should only be seen as a very small, slightly-incremental step towards testing on more and more embedded, "no-std" target environments.
Building & testing with
cross-rsfor many embedded targets seems to be limited by the following issues:crossdocker images (there may be some others out there in the wild)aws-lc-rs/aws-lc-sysrequires some bindgen setup to build for most of the targets other than the normal Windows / /macOS / normal headless Linux targets. And it looks to me like even if we would not enable theaws_lc_rsfeature,cross testwould still includeaws-lc-rs/aws-lc-sysdue to thisdev-depenenciesentry needed forrustls/examples/internal/test_ca.rs:rcgen = { version = "0.13", default-features = false, features = ["aws_lc_rs", "pem"] }SOME HELPFUL RESOURCES: