Skip to content

remove Send + Sync not needed from client session storage field #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

remove Send + Sync not needed from client session storage field #2087

merged 1 commit into from
Aug 23, 2024

Conversation

brody4hire
Copy link
Contributor

While working on a proposal to support using alloc::rc::Rc, as discussed as a possible solution for #2068, I discovered a case of extra Send + Sync that I think is not needed & one more thing that would need to be updated. Of course I could remove this as part of my proposal for #2068, but would rather keep this kind of cleanup in a separate proposal & commit if possible.

FYI I did already get a green build of this proposal in my own fork.

@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.78%. Comparing base (f17866c) to head (b59098c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2087   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         102      102           
  Lines       23497    23497           
=======================================
  Hits        22271    22271           
  Misses       1226     1226

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brody4hire brody4hire mentioned this pull request Aug 23, 2024
Closed
djc
djc approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have these bounds on any of the other Arc<dyn>s in the ServerConfig (or ClientConfig), I suppose this is fine.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Aug 23, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2140685 2136144 ✅ -4541 (-0.21%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5090048 5153030 62982 (1.24%) 2.33%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3957031 3938143 -18888 (-0.48%) 3.70%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8876290 8906681 30391 (0.34%) 0.79%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31200621 31134126 -66495 (-0.21%) 0.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30751851 30686424 -65427 (-0.21%) 0.50%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13454524 13428006 -26518 (-0.20%) 1.36%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2138759 2134603 -4156 (-0.19%) 0.77%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3919558 3912873 -6685 (-0.17%) 0.44%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33012215 32962138 -50077 (-0.15%) 0.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3379604 3384425 4821 (0.14%) 0.24%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3920519 3916469 -4050 (-0.10%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13831284 13845546 14262 (0.10%) 0.95%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13850717 13839183 -11534 (-0.08%) 0.71%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58255436 58210466 -44970 (-0.08%) 0.22%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46377282 46352576 -24706 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32941820 32959290 17470 (0.05%) 0.56%
handshake_session_id_ring_1.2_rsa_aes_server 4267115 4265843 -1272 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46388597 46402123 13526 (0.03%) 0.61%
handshake_session_id_ring_1.2_rsa_aes_client 4285315 4284287 -1028 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1920312 1919863 -449 (-0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4704039 4702953 -1086 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8887328 8889374 2046 (0.02%) 1.36%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34716798 34709379 -7419 (-0.02%) 0.46%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4442303 4443216 913 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80592826 80605729 12903 (0.02%) 0.24%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42405007 42411701 6694 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42338050 42344605 6555 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30720486 30716161 -4325 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92700188 92687324 -12864 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31097135 31101020 3885 (0.01%) 0.50%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80499706 80508780 9074 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58326323 58332653 6330 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44034108 44038875 4767 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30721841 30725053 3212 (0.01%) 0.32%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43954689 43959202 4513 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2957288 2957585 297 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41881173 41885256 4083 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43458920 43463081 4161 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43365826 43369923 4097 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92659568 92668126 8558 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46446678 46450743 4065 (0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2853934 2854152 218 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41957279 41960424 3145 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1916823 1916959 136 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92707443 92702924 -4519 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2017119 2017029 -90 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43462393 43464235 1842 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33002584 33001300 -1284 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2951814 2951707 -107 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2235484 2235405 -79 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11992037 11992453 416 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30741476 30740551 -925 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34772218 34771185 -1033 (-0.00%) 0.60%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4393542 4393671 129 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43954817 43955972 1155 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32959984 32960848 864 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31121460 31120667 -793 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34785757 34786630 873 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3381315 3381398 83 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42422752 42423787 1035 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4026652 4026736 84 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43366650 43365751 -899 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31169910 31169312 -598 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33001412 33002018 606 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44038712 44037937 -775 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13744330 13744090 -240 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58327798 58328784 986 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42358173 42358859 686 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12180138 12179955 -183 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41876833 41876251 -582 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41893293 41893858 565 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4556984 4556924 -60 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2228252 2228227 -25 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42340305 42339839 -466 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46454081 46454592 511 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41956679 41957107 428 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31192510 31192195 -315 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30759114 30759411 297 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46368604 46368161 -443 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80605989 80606740 751 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43460401 43460046 -355 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41974265 41973926 -339 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58244868 58245323 455 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43362186 43362507 321 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44035396 44035716 320 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30733790 30733996 206 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32961364 32961146 -218 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43958342 43958595 253 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58209062 58208827 -235 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13742154 13742099 -55 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12186044 12185997 -47 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92664961 92664617 -344 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4390169 4390153 -16 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35474057 35473943 -114 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34787174 34787283 109 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80608021 80607782 -239 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58247732 58247609 -123 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80507612 80507769 157 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34767397 34767455 58 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92660522 92660370 -152 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80515751 80515882 131 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92705418 92705568 150 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46428722 46428657 -65 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475997 35475952 -45 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34766609 34766650 41 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46462637 46462678 41 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31145215 31145190 -25 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42404454 42404420 -34 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46427109 46427136 27 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68666201 68666237 36 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58331833 58331828 -5 (-0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.51 ms 5.57 ms ⚠️ 0.06 ms (1.15%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.38 ms 5.44 ms ⚠️ 0.06 ms (1.10%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.22 ms 6.29 ms ⚠️ 0.06 ms (1.01%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.09 ms 6.15 ms ⚠️ 0.06 ms (1.00%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.48 ms 6.54 ms ⚠️ 0.06 ms (1.00%) 1.00%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.47 ms 4.59 ms 0.12 ms (2.69%) 4.46%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.31 ms 0.12 ms (2.29%) 4.21%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.43 ms 5.55 ms 0.12 ms (2.21%) 3.44%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.43 ms 5.55 ms 0.12 ms (2.21%) 3.09%
transfer_no_resume_ring_1.3_rsa_aes 6.80 ms 6.92 ms 0.12 ms (1.77%) 2.95%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 480.43 µs 488.65 µs 8.22 µs (1.71%) 2.77%
transfer_no_resume_ring_1.2_rsa_aes 6.70 ms 6.82 ms 0.11 ms (1.71%) 2.55%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.32 ms 6.43 ms 0.11 ms (1.68%) 2.81%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 479.70 µs 487.68 µs 7.98 µs (1.66%) 3.09%
handshake_no_resume_ring_1.3_ecdsap256_aes 506.43 µs 514.71 µs 8.28 µs (1.64%) 2.70%
handshake_no_resume_ring_1.3_ecdsap256_chacha 504.55 µs 511.94 µs 7.39 µs (1.46%) 2.54%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.41 ms 9.52 ms 0.11 ms (1.19%) 1.91%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.50 ms 5.56 ms 0.05 ms (0.97%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.35 ms 6.41 ms 0.06 ms (0.96%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.93 ms 13.05 ms 0.12 ms (0.92%) 1.47%
transfer_no_resume_ring_1.3_rsa_chacha 13.45 ms 13.57 ms 0.12 ms (0.91%) 1.33%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 13.06 ms 0.12 ms (0.90%) 1.39%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.40 ms 5.45 ms 0.05 ms (0.86%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.48 ms 6.53 ms 0.06 ms (0.86%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.22 ms 6.27 ms 0.05 ms (0.86%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.90 ms 14.02 ms 0.12 ms (0.85%) 1.31%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.66 ms 13.77 ms 0.11 ms (0.83%) 1.13%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.37 ms 6.43 ms 0.05 ms (0.82%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.11 ms 6.16 ms 0.05 ms (0.78%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 1.01 ms 0.01 ms (0.77%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.79 ms 6.84 ms 0.05 ms (0.74%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.67 ms 0.01 ms (0.74%) 1.47%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.16 ms 0.11 ms (0.70%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 1.00 ms 1.01 ms 0.01 ms (0.68%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms 0.01 ms (0.68%) 1.10%
handshake_no_resume_ring_1.2_rsa_aes 976.61 µs 983.18 µs 6.57 µs (0.67%) 1.27%
handshake_session_id_ring_1.3_ecdsap256_aes 6.74 ms 6.79 ms 0.04 ms (0.64%) 1.11%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.19 ms 1.20 ms 0.01 ms (0.64%) 1.19%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.30 ms 2.32 ms 0.01 ms (0.63%) 1.95%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.75 ms 6.79 ms 0.04 ms (0.62%) 1.25%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.70 ms 6.74 ms 0.04 ms (0.60%) 1.18%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.44 ms 1.45 ms 0.01 ms (0.57%) 5.72%
handshake_session_id_ring_1.3_rsa_chacha 7.19 ms 7.23 ms 0.04 ms (0.51%) 1.50%
handshake_tickets_ring_1.3_rsa_aes 7.29 ms 7.33 ms 0.04 ms (0.51%) 1.08%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.58 ms 0.01 ms (0.50%) 1.10%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.11 ms 2.12 ms 0.01 ms (0.49%) 2.68%
handshake_session_id_ring_1.3_rsa_aes 7.24 ms 7.28 ms 0.04 ms (0.49%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.38 ms 1.39 ms 0.01 ms (0.47%) 6.06%
handshake_tickets_ring_1.3_rsa_chacha 7.24 ms 7.27 ms 0.03 ms (0.46%) 1.21%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.43 ms 1.44 ms 0.01 ms (0.41%) 6.20%
handshake_tickets_ring_1.3_ecdsap384_aes 9.88 ms 9.92 ms 0.04 ms (0.40%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.83 ms 9.86 ms 0.03 ms (0.32%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.79 ms 9.82 ms 0.03 ms (0.31%) 1.04%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.84 ms 9.87 ms 0.03 ms (0.29%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.61 ms 0.01 ms (0.18%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.11%) 1.00%

Additional information

Historical results

Checkout details:

ctz
ctz approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(I missed it initially, but this is good because StoresServerSessions already has Send + Sync as trait bounds. That should be a clippy lint!)

@ctz ctz added this pull request to the merge queue Aug 23, 2024
Merged via the queue into rustls:main with commit df312f2 Aug 23, 2024
25 checks passed
@brody4hire brody4hire deleted the cleanup-client-session-storage-field branch August 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brody4hire @djc @ctz