Optimise crate size #2077
Merged
Optimise crate size #2077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 102 102
Lines 23465 23465
=======================================
Hits 22180 22180
Misses 1285 1285 ☔ View full report in Codecov by Sentry. |
ctz
commented
Aug 8, 2024
| @@ -60,39 +60,244 @@ impl<'a> FfdheGroup<'a> { | |||
| /// | |||
| /// [RFC 7919 Appendix A.1]: https://datatracker.ietf.org/doc/html/rfc7919#appendix-A.1 | |||
| pub const FFDHE2048: FfdheGroup<'static> = FfdheGroup { | |||
| p: include_bytes!("ffdhe_groups/ffdhe2048-modulus.bin"), | |||
| p: &[ | |||
There was a problem hiding this comment.
On this commit, I checked we had working test coverage by introducing a one-bit error into all of these locally, and checking the validation caught it. It did.
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
cpu
approved these changes
Aug 8, 2024
djc
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2076
This takes rustls.crate from 434KB to 334KB, which translates to saving crates.io (and, indeed, downloaders) about 50 GB per day.