Skip to content

Avoid markdown footnotes #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2024
Merged

Avoid markdown footnotes #2033

merged 1 commit into from
Jul 5, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Jul 5, 2024

These are apparently non-standard(?) and don't show well in rust doc anyway. They looked like:

Screenshot from 2024-07-05 13-34-31

Now this looks like:

image

As of rust-lang/rust#127127 this is now a warning.

@ctz
Avoid markdown footnotes
e733ff5 
These are apparently non-standard(?) and don't show well in
rust doc anyway.
cpu
cpu approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jul 5, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4007995 3884998 -122997 (-3.07%) 6.18%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4472245 4438929 -33316 (-0.74%) 3.90%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13352504 13430184 77680 (0.58%) 0.89%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13784028 13723375 -60653 (-0.44%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13805758 13765719 -40039 (-0.29%) 0.78%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33507509 33585755 78246 (0.23%) 0.48%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32936032 33005092 69060 (0.21%) 0.54%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2131598 2135888 4290 (0.20%) 0.81%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2133409 2137670 4261 (0.20%) 0.82%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8766950 8781295 14345 (0.16%) 0.71%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31079925 31122377 42452 (0.14%) 0.30%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46421774 46481382 59608 (0.13%) 0.34%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3916286 3920585 4299 (0.11%) 0.47%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3915794 3919868 4074 (0.10%) 0.33%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46432448 46393269 -39179 (-0.08%) 0.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8789411 8783061 -6350 (-0.07%) 0.98%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31097922 31116884 18962 (0.06%) 0.39%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32955896 32938937 -16959 (-0.05%) 0.67%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33530098 33541988 11890 (0.04%) 0.59%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58205682 58226024 20342 (0.03%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4692252 4691087 -1165 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30637546 30632655 -4891 (-0.02%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1912620 1912341 -279 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661866 80673157 11291 (0.01%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4292278 4291734 -544 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1915910 1915690 -220 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2854081 2853754 -327 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43376818 43371994 -4824 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4529652 4529151 -501 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3385447 3385814 367 (0.01%) 0.28%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2016680 2016486 -194 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41821577 41817728 -3849 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92711113 92719224 8111 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30658001 30660582 2581 (0.01%) 0.41%
handshake_no_resume_ring_1.3_rsa_aes_client 2951040 2951280 240 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3382735 3382476 -259 (-0.01%) 0.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30678747 30680699 1952 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31140051 31141831 1780 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42344626 42342326 -2300 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30655250 30653634 -1616 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58256745 58259523 2778 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32946235 32944830 -1405 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42339050 42340801 1751 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2956701 2956586 -115 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92650794 92653816 3022 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92714257 92717281 3024 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43470098 43471457 1359 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2234424 2234492 68 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 33553619 33554619 1000 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32986047 32987008 961 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44045259 44044054 -1205 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4000943 4000834 -109 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13741726 13741372 -354 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41891599 41890551 -1048 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4252177 4252273 96 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41827433 41828343 910 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41895958 41896831 873 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30668863 30668285 -578 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44041554 44042364 810 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43368424 43367647 -777 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44044321 44045040 719 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41909558 41908874 -684 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 33521773 33522308 535 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31158806 31159303 497 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4295307 4295240 -67 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42293030 42292379 -651 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31121955 31121479 -476 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46451847 46452525 678 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2227380 2227411 31 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43961302 43960710 -592 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13739621 13739777 156 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58319219 58318575 -644 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43961143 43961622 479 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32945135 32945491 356 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32985676 32986027 351 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475746 35475393 -353 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 33521989 33521662 -327 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42273705 42274083 378 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42357937 42358311 374 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46453361 46452967 -394 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42278834 42279181 347 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12177561 12177464 -97 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4264541 4264513 -28 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30693842 30693679 -163 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80631766 80631361 -405 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58262472 58262191 -281 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58318412 58318152 -260 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41809066 41809246 180 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80632028 80632357 329 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43472433 43472606 173 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11988593 11988639 46 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 33555124 33555251 127 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43958218 43958052 -166 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12183377 12183422 45 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46457861 46458032 171 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31139137 31139241 104 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473703 35473801 98 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46375863 46375738 -125 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58200284 58200438 154 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43372096 43372210 114 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46461992 46461882 -110 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43473406 43473314 -92 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4324916 4324925 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92647822 92647639 -183 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58314733 58314635 -98 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92652293 92652413 120 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80530276 80530375 99 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92719317 92719419 102 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80538805 80538724 -81 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46470119 46470082 -37 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80526561 80526620 59 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68658176 68658220 44 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsap256_chacha 510.34 µs 512.94 µs 2.60 µs (0.51%) 2.04%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 486.73 µs 488.33 µs 1.60 µs (0.33%) 2.89%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.44 ms 5.45 ms 0.02 ms (0.31%) 1.47%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 487.27 µs 488.75 µs 1.48 µs (0.30%) 2.77%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.37 ms 5.38 ms 0.02 ms (0.29%) 1.21%
handshake_session_id_ring_1.2_rsa_aes 1.58 ms 1.58 ms -0.00 ms (-0.24%) 1.39%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.36 ms 6.37 ms 0.01 ms (0.23%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.10 ms 6.11 ms 0.01 ms (0.21%) 1.03%
handshake_tickets_ring_1.3_rsa_chacha 7.24 ms 7.25 ms 0.01 ms (0.20%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.15 ms 6.16 ms 0.01 ms (0.19%) 1.08%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.16 ms 6.17 ms 0.01 ms (0.19%) 1.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.44 ms 5.45 ms 0.01 ms (0.18%) 1.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.39 ms 5.40 ms 0.01 ms (0.16%) 1.28%
handshake_tickets_ring_1.3_rsa_aes 7.28 ms 7.30 ms 0.01 ms (0.16%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.43 ms 1.44 ms 0.00 ms (0.16%) 3.52%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.41 ms 6.42 ms 0.01 ms (0.15%) 1.19%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.79 ms 9.80 ms 0.01 ms (0.14%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 994.25 µs 995.67 µs 1.42 µs (0.14%) 1.13%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.85 ms 9.86 ms 0.01 ms (0.13%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.34 ms 6.35 ms 0.01 ms (0.13%) 1.07%
handshake_session_id_ring_1.3_rsa_chacha 7.19 ms 7.20 ms 0.01 ms (0.13%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.89 ms 9.90 ms 0.01 ms (0.13%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.67 ms 1.67 ms -0.00 ms (-0.12%) 1.31%
handshake_no_resume_ring_1.3_ecdsap256_aes 512.55 µs 513.16 µs 0.61 µs (0.12%) 2.35%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.41 ms 6.42 ms 0.01 ms (0.12%) 1.07%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.45 ms 1.44 ms -0.00 ms (-0.11%) 3.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.19 ms 1.20 ms 0.00 ms (0.11%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.09 ms 2.10 ms 0.00 ms (0.11%) 1.36%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.07 ms 6.08 ms 0.01 ms (0.11%) 1.06%
handshake_session_id_ring_1.3_ecdsap384_aes 9.83 ms 9.84 ms 0.01 ms (0.10%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 981.31 µs 982.28 µs 0.97 µs (0.10%) 1.12%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.76 ms 6.77 ms 0.01 ms (0.09%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.27 ms 2.27 ms -0.00 ms (-0.08%) 1.77%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.61 ms 0.00 ms (0.08%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.39 ms 1.39 ms -0.00 ms (-0.08%) 2.79%
handshake_session_id_ring_1.3_rsa_aes 7.24 ms 7.25 ms 0.01 ms (0.07%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 6.89 ms 6.90 ms 0.00 ms (0.07%) 2.67%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.21 ms 1.20 ms -0.00 ms (-0.06%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.54 ms 13.55 ms 0.01 ms (0.05%) 1.32%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.42 ms 6.42 ms 0.00 ms (0.05%) 3.07%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.05 ms 13.06 ms 0.01 ms (0.04%) 1.53%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.55 ms 5.55 ms 0.00 ms (0.04%) 3.23%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.51 ms 9.52 ms 0.00 ms (0.04%) 1.73%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.71 ms 6.71 ms 0.00 ms (0.04%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.59 ms 4.59 ms 0.00 ms (0.03%) 3.99%
handshake_tickets_ring_1.3_ecdsap256_aes 6.81 ms 6.81 ms 0.00 ms (0.03%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.75 ms 6.75 ms 0.00 ms (0.03%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.16 ms 16.16 ms -0.00 ms (-0.02%) 1.22%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.54 ms 5.53 ms -0.00 ms (-0.02%) 3.03%
transfer_no_resume_ring_1.2_rsa_aes 6.82 ms 6.82 ms -0.00 ms (-0.02%) 2.95%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.31 ms 5.31 ms 0.00 ms (0.02%) 3.27%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.76 ms 13.76 ms -0.00 ms (-0.02%) 1.32%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.02 ms 14.02 ms 0.00 ms (0.02%) 1.40%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms 0.00 ms (0.01%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.06 ms 13.06 ms -0.00 ms (-0.01%) 1.37%
handshake_no_resume_ring_1.3_rsa_chacha 994.80 µs 994.75 µs -0.06 µs (-0.01%) 1.27%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (cc393e7) to head (e733ff5).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2033   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files          97       97           
  Lines       21841    21841           
=======================================
  Hits        20595    20595           
  Misses       1246     1246

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 0a0359f Jul 5, 2024
@ctz ctz deleted the jbp-avoid-markdown-footnotes branch July 5, 2024 13:06
This was referenced Jul 6, 2024
Merged
Merged
@notriddle
Copy link

notriddle commented Jul 9, 2024 •
edited
Loading

Just to be clear, you got a warning because you forgot the ^ on the footnote definition. You could have fixed the warning this way:

-[0]: https://www.rfc-editor.org/rfc/rfc9180.html#section-5.1
+[^0]: https://www.rfc-editor.org/rfc/rfc9180.html#section-5.1

If you want to use footnotes and have them continue to work, try writing the Markdown you want in a GitHub comment and see if the preview tab looks right.

@ctz ctz mentioned this pull request Aug 29, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctz @notriddle @djc @cpu