Skip to content

Conversation

djc
Copy link
Member

@djc djc commented Mar 9, 2025

(Semver-compatible dependencies were upgraded in #162.)

Fixes #164.

@djc djc marked this pull request as draft March 9, 2025 09:43
@djc djc force-pushed the update-deps branch 2 times, most recently from 1d1c2b7 to 53b2176 Compare March 17, 2025 12:29
@djc djc marked this pull request as ready for review March 17, 2025 12:43
@djc
Copy link
Member Author

djc commented Mar 17, 2025

Because rustls-platform-verifier pierces that dyn Error abstraction of rustls' use of webpki (see for more details rustls/rustls#2384, which works towards a long-term solution), all crates downstream of rustls-platform-verifier will be broken on upgrading to rustls 0.23.24 until this is released -- so let's try to get this released soon?

@cpu
Copy link
Member

cpu commented Mar 17, 2025

CI / Check semver compatibility (pull_request) Failing after 40s
..
--- failure feature_missing: package feature removed or renamed ---

This was the removal of the paste feature for the dev-dep right? I think so, just wanted to verify.

@cpu
Copy link
Member

cpu commented Mar 17, 2025

Looks like one more Android test error mismatch to fix up:

verification_real_world: verifying ref ID "agilebits.com" expected Err(InvalidCertificate(NotValidForName))
03-17 14:01:39.417  3231  3272 E rustls_platform_verifier::verification::android: failed to verify TLS certificate: invalid peer certificate: certificate not valid for name "agilebits.com"; certificate is only valid for DnsName("*.1password.com") or DnsName("1password.com")
03-17 14:01:39.417  3231  3272 E rustls_platform_verifier::tests::ffi::android: test panic: assertion `left == right` failed
03-17 14:01:39.417  3231  3272 E rustls_platform_verifier::tests::ffi::android:   left: Err(InvalidCertificate(NotValidForNameContext { expected: DnsName("agilebits.com"), presented: ["DnsName(\"*.1password.com\")", "DnsName(\"1password.com\")"] }))
03-17 14:01:39.417  3231  3272 E rustls_platform_verifier::tests::ffi::android:  right: Err(InvalidCertificate(NotValidForName))

@djc
Copy link
Member Author

djc commented Mar 17, 2025

CI / Check semver compatibility (pull_request) Failing after 40s
..
--- failure feature_missing: package feature removed or renamed ---

This was the removal of the paste feature for the dev-dep right? I think so, just wanted to verify.

Yup!

Copy link
Collaborator

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond @ctz's comment I didn't see anything noteworthy here so this looks good to go.

@djc were you intending me to handle publishing a new update once this is merged to main?

@djc
Copy link
Member Author

djc commented Mar 17, 2025

Beyond @ctz's comment I didn't see anything noteworthy here so this looks good to go.

@djc were you intending me to handle publishing a new update once this is merged to main?

Nope, I can take care of it!

@djc djc merged commit d4c0b81 into main Mar 17, 2025
21 of 22 checks passed
@djc djc deleted the update-deps branch March 17, 2025 14:57
@complexspaces
Copy link
Collaborator

Beyond @ctz's comment I didn't see anything noteworthy here so this looks good to go.
@djc were you intending me to handle publishing a new update once this is merged to main?

Nope, I can take care of it!

Sure, that sounds fine to me as well 👍. Thank you for handling it.

I was just asking to make sure any expectations were clear since this is an important patch release to get pushed.

@djc
Copy link
Member Author

djc commented Mar 17, 2025

  • Published rustls-platform-verifier v0.5.1 at registry crates-io
  • [new tag] v/0.5.1 -> v/0.5.1
  • Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: disabling default-features on webpki fails builds that depend on quinn on Linux
4 participants