Move AlgorithmIdentifier values to here from rustls-webpki
#67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any downstream crate defining a custom `rustls::CryptoProvider` currently needs to take a dependency on `rustls-webpki` to reuse these values (alternatively they can redefine these values, but meh.) Moving them here removes that need.
> 'go get' is no longer supported outside a module. > To build and install a command, use 'go install' with a version, > like 'go install example.com/cmd@latest'
The intention here is to make it easy to cross-reference these values with other sources of information, and to "lift the veil" on what these things actually are and are not. Some of these are trivial (ed25519) while others reveal their true horror (RSA-PSS). For the latter, include a reference to their defining RFC, and decorate the context-specific fields with their name in comments.
cpu
approved these changes
Dec 23, 2024
|
How about we move AlgorithmIdentifier into the new module, with a top-level re-export for compatibility? |
djc
approved these changes
Dec 23, 2024
|
@ctz Any thoughts on Djc's last feedback? Should we hold merge on that? |
0193439 to
fec0ec9
Compare
Added a commit for this. I could take it or leave it to be honest, but see what you think. |
djc
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any downstream crate defining a custom
rustls::CryptoProvidercurrently needs to take a dependency onrustls-webpkito reuse these values (alternatively they can redefine these values, but meh.)Moving them here removes that need, and eliminates another reason for people to depend on
rustls-webpkidirectly.fixes #27