Skip to content

Conversation

djc
Copy link
Member

@djc djc commented Apr 10, 2025

Forgot these in #343.

@djc djc requested review from cpu and ctz April 10, 2025 14:33
@ctz
Copy link
Member

ctz commented Apr 10, 2025

Maybe we should move the remaining uses of these files from custom_ekus.rs into client_auth.rs?

edit: and then drop the remaining single test in custom_ekus.rs into integration.rs?

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (7badc0e) to head (9847aea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          20       20           
  Lines        4348     4348           
=======================================
  Hits         4251     4251           
  Misses         97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc
Copy link
Member Author

djc commented Apr 10, 2025

Maybe we should move the remaining uses of these files from custom_ekus.rs into client_auth.rs?

edit: and then drop the remaining single test in custom_ekus.rs into integration.rs?

Went a slightly different route? Will probably do more work on this soon.

@djc djc added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 85d885d Apr 10, 2025
64 checks passed
@djc djc deleted the rm-test-certs branch April 10, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants