Skip to content

Allow x509v3 empty extensions (redux) #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Allow x509v3 empty extensions (redux) #342

merged 2 commits into from
Apr 9, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Apr 9, 2025

fixes #336 #335

ctz
ctz commented Apr 9, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (00249a9) to head (5172f77).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          20       20           
  Lines        4343     4348    +5     
=======================================
+ Hits         4246     4251    +5     
  Misses         97       97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz requested a review from djc April 9, 2025 10:03
djc
djc approved these changes Apr 9, 2025
View reviewed changes
@djc djc mentioned this pull request Apr 9, 2025
Closed
@ctz ctz force-pushed the jbp-empty-extensions branch from da9d219 to 5172f77 Compare April 9, 2025 13:36
@ctz ctz enabled auto-merge April 9, 2025 13:40
@ctz ctz added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit 2efb15e Apr 9, 2025
64 checks passed
@ctz ctz deleted the jbp-empty-extensions branch April 9, 2025 13:49
@ctz ctz mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @main--