Fix CI build failures, tidy cargo-deny config #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cpu
commented
Apr 4, 2025
- Updates semver compat deps to avoid a CMake compatibility issue.
- Removes RUSTSEC-2024-0436 ignore: it's been fixed upstream in aws-lc-rs.
- Adds some new flake8 lint ignores to fix the Python testgen task failures.
This has been fixed in aws-lc-rs upstream.
Our CI flake8 updated 7.1 -> 7.2 and now reports: ``` ./tests/generate.py:690:9: F824 `nonlocal message_path` is unused: name is never assigned in scope ./tests/generate.py:1173:13: F824 `nonlocal crl_paths` is unused: name is never assigned in scope ./tests/generate.py:1173:13: F824 `nonlocal expected_error` is unused: name is never assigned in scope ./tests/generate.py:1173:13: F824 `nonlocal intermediates_str` is unused: name is never assigned in scope ./tests/generate.py:1173:13: F824 `nonlocal ee_cert_path` is unused: name is never assigned in scope ./tests/generate.py:1173:13: F824 `nonlocal root_cert_path` is unused: name is never assigned in scope ``` The values are assigned at a higher scope and while, gross, It Works, so let's ignore it for now and one day rewrite this mess in Rust :P
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 20 20
Lines 4343 4343
=======================================
Hits 4246 4246
Misses 97 97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ctz
approved these changes
Apr 4, 2025
djc
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.