Skip to content

Cargo: ring 0.17.8 -> 0.17.13 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2025
Merged

Cargo: ring 0.17.8 -> 0.17.13 #329

merged 3 commits into from
Mar 7, 2025

Conversation

cpu
Copy link
Member

@cpu cpu commented Mar 7, 2025 •
edited
Loading

Updating ring v0.17.8 -> v0.17.13

Also a few small cargo deny fixes:

  • deny: remove LicenseRef-ring: This license is no longer being encountered by cargo deny after *ring* 0.17.10 incorporated the upstream BoringSSL relicense work.
  • deny: ignore RUSTSEC-2024-0436 - we'll follow the upstream progress on this one.

@cpu
Cargo: ring 0.17.8 -> 0.17.13
45d9721 
Updating ring v0.17.8 -> v0.17.13
@cpu cpu self-assigned this Mar 7, 2025
@cpu
Copy link
Member Author

cpu commented Mar 7, 2025

ci / Cargo Deny (pull_request) Failing after 9s

This is paste being flagged unmaintained. It's a transitive dep through aws-lc-rs, and they're aware: aws/aws-lc-rs#722

@codecov Codecov
Copy link

codecov bot commented Mar 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (7cb0aa7) to head (d64758d).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          20       20           
  Lines        4343     4343           
=======================================
  Hits         4246     4246           
  Misses         97       97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz
Copy link
Member

ctz commented Mar 7, 2025

Can this PR also edit deny.toml to remove the "LicenseRef-ring" business?

cpu added 2 commits March 7, 2025 14:17
@cpu
deny: remove LicenseRef-ring
71bb891 
This license is no longer being encountered by `cargo deny` after
`*ring*` 0.17.10 incorporated the upstream BoringSSL relicense work.
@cpu
deny: ignore RUSTSEC-2024-0436
d64758d 
https://rustsec.org/advisories/RUSTSEC-2024-0436
@cpu
Copy link
Member Author

cpu commented Mar 7, 2025

Can this PR also edit deny.toml to remove the "LicenseRef-ring" business?

Good catch, thanks! tacked on a commit for that.

This is paste being flagged unmaintained. It's a transitive dep through aws-lc-rs

Added an ignore for this with a ref to the upstream issue.

@cpu cpu enabled auto-merge March 7, 2025 19:23
@cpu cpu added this pull request to the merge queue Mar 7, 2025
Merged via the queue into rustls:main with commit 51ca321 Mar 7, 2025
33 checks passed
@cpu cpu deleted the cpu-ring-bump branch March 7, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@ctz ctz ctz approved these changes

Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpu @ctz @djc