show TCP/UDP/IPv6 in tooltip #12613
Merged
show TCP/UDP/IPv6 in tooltip #12613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 21pages <sunboeasy@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: 21pages <sunboeasy@gmail.com>
65330b9 to
95db184
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the connection information display by adding stream type details (TCP/UDP/IPv6) to tooltips and logs. It improves user visibility into the actual connection mechanism being used for remote connections.
- Adds punch type logging to better track connection establishment attempts
- Displays connection stream type (TCP/UDP/IPv6) in UI tooltips alongside existing security/direct indicators
- Skips UDP punch attempts when UDP NAT port is 0, treating them as TCP punches
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/client.rs | Core logic for tracking and returning stream type information during connection establishment |
| src/ui_session_interface.rs | Updates interface to pass stream type parameter to UI handlers |
| src/ui/remote.rs | Sciter UI handler updated to receive and process stream type information |
| src/ui/header.tis | JavaScript logic to display stream type in connection tooltips |
| src/flutter.rs | Flutter handler updated to include stream type in connection events |
| src/client/io_loop.rs | Connection loop updated to pass stream type to UI |
| src/port_forward.rs | Port forwarding client updated to handle new stream type return value |
| flutter/lib/models/model.dart | Flutter model updated to store and display connection type with stream information |
| flutter/lib/mobile/pages/*.dart | Mobile UI pages updated to use new connection display method |
| flutter/lib/desktop/pages/*.dart | Desktop UI pages updated to use centralized connection text generation |
| flutter/lib/common/shared_state.dart | Shared state updated to track stream type |
| flutter/lib/common.dart | New utility function for generating connection text with stream type |
95db184 to
6169cfe
Compare
Signed-off-by: 21pages <sunboeasy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
Punch Test
TCP local addr, UDP punch hole, IPv6 local addr/Punch Hole, force relay with nightly to nightly/1.3.9
Tooltip
skip udp punch