macOS: Try getentropy() then fallback to /dev/random #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also update |
Done, I had to link to unix.com's man pages as there doesn't seem to be a good way to view macOS manpages on Apple's website. |
|
Great! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38. As we moved files around
macos.rs -> ios.rsthe diff for this PR is weird. However, the diffs for each individual commit are fine, so review will be easier if you look at those.As
/dev/randomand/dev/urandomare the same on macOS. We just use/dev/randomto keep ouruse_fileimplementation simple.Tested on macOS with and without
getentropy(2)