Skip to content

bug-2672 #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021
Merged

bug-2672 #2695

merged 1 commit into from
Mar 17, 2021

Conversation

rbtcollins
Copy link
Contributor

We need a two-step process for this. Step 1 is to announce the
deprecation of no-force options on update/install of toolchains and
accept --force. Step 2, in the next release, is to make --force actually
required.

@kinnison
Copy link
Contributor

Is your hope that the presence of the error: will trigger some CIs to fail, causing people to update sooner?

I think we need to ponder the wording carefully, as well as the timing of requiring --force but the concept is good. I don't personally have a problem with the wording you chose, but I'm aware that in the past my judgement on these kinds of things isn't great. I wonder if we could get some help from the compiler's error messages team?

@rbtcollins
Copy link
Contributor Author

The error won't cause a exit code of 1, but it will pollute stderr. I hope folk will notice it and update. I intend to file a bug on cross and get them to update immediately, so that they are ready for our next release where we conceptually do the actual enforcement.

@kinnison
Copy link
Contributor

A lot of people shouted at me that I'd break CI systems for emitting a deprecation error (but not failing to run) because of systems scanning stderr for 'error:' so I guess they'd notice pretty quickly if that's the case. Honestly this is such a corner case of use, providing cross works properly that I don't mind.

I wonder if we should have a specific flag for this though, since --force implies more than just this particular override. Again I don't mind if you think we should keep things simple.

@rbtcollins
Copy link
Contributor Author

Talking to people about the error message sounds like a fine idea; perhaps we can ask at the wg-sync? I can add a -not-host suffix to this flag easily, and its nice future proofing, so sure lets do that.

We need a two-step process for this. Step 1 is to announce the
deprecation of no-force options on update/install of toolchains and
accept --force. Step 2, in the next release, is to make --force actually
required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants