Skip to content

Conversation

J-ZhengLi
Copy link
Member

fixes: #12731


changelog: make [from_str_radix_10] skip constant context

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 11, 2024
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented May 12, 2024

@bors r+

@bors
Copy link
Contributor

bors commented May 12, 2024

📌 Commit 904c99c has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 12, 2024

⌛ Testing commit 904c99c with merge 9b446c7...

@bors
Copy link
Contributor

bors commented May 12, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 9b446c7 to master...

@bors bors merged commit 9b446c7 into rust-lang:master May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_str_radix_10 lint shows up in const contexts when the suggestion is not const
4 participants