Skip to content

Needless pass by ref mut closure non async fn #11621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2023
Merged

Needless pass by ref mut closure non async fn #11621

merged 3 commits into from
Oct 19, 2023

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 6, 2023 •
edited by blyxyas
Loading

Fixes #11620.
Fixes #11561.

changelog: [needless_pass_by_ref_mut]: Correctly handle arguments moved into closure in non-async functions.

r? @Centri3

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 6, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 6, 2023
Closed
Centri3
Centri3 reviewed Oct 6, 2023
View reviewed changes
@GuillaumeGomez GuillaumeGomez force-pushed the needless_pass_by_ref_mut-closure-non-async-fn branch from a1581e0 to 6b12bcc Compare October 6, 2023 12:14
@GuillaumeGomez
Copy link
Member Author

Updated!

@GuillaumeGomez
Copy link
Member Author

Seems like Centri3 is busy so I was recommended another reviewer.

r? @blyxyas

@rustbot rustbot assigned blyxyas and unassigned Centri3 Oct 17, 2023
@bors
Copy link
Contributor

bors commented Oct 17, 2023

☔ The latest upstream changes (presumably #11622) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez GuillaumeGomez force-pushed the needless_pass_by_ref_mut-closure-non-async-fn branch from 6b12bcc to 800ecf5 Compare October 17, 2023 13:38
@GuillaumeGomez
Copy link
Member Author

Fixed conflict.

@bors
Copy link
Contributor

bors commented Oct 18, 2023

☔ The latest upstream changes (presumably #11624) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez GuillaumeGomez force-pushed the needless_pass_by_ref_mut-closure-non-async-fn branch from 800ecf5 to 3e6db95 Compare October 18, 2023 19:19
@GuillaumeGomez
Copy link
Member Author

Fixed the conflict.

blyxyas
blyxyas approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Oct 19, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Oct 19, 2023

📌 Commit 3e6db95 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 19, 2023

⌛ Testing commit 3e6db95 with merge cd477d4...

@bors
Copy link
Contributor

bors commented Oct 19, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing cd477d4 to master...

@bors bors merged commit cd477d4 into rust-lang:master Oct 19, 2023
@GuillaumeGomez GuillaumeGomez deleted the needless_pass_by_ref_mut-closure-non-async-fn branch October 19, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centri3 Centri3 Centri3 left review comments

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

needless_pass_by_ref_mut: false positive with closures needless_pass_by_ref_mut false positive in closure
5 participants
@GuillaumeGomez @bors @blyxyas @Centri3 @rustbot