Skip to content

Conversation

pitaj
Copy link
Contributor

@pitaj pitaj commented Sep 16, 2023

rust-lang/triagebot#1720

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2023

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 16, 2023
@xFrednet
Copy link
Contributor

Clippy doesn't have the has-merge-commits label, not sure if it's worth adding it. 🤔 The Rustup title check might be nice, though.

r? @flip1995 since you usually do the updates. Do you want to have fewer conversations with @rustbot? ^^

@rustbot rustbot assigned flip1995 and unassigned Alexendoo Sep 16, 2023
@pitaj
Copy link
Contributor Author

pitaj commented Sep 16, 2023

Adding the label is low cost IMO. It's a visible reminder to the reviewer that can't get lost in a sea of comments, and bors may eventually become aware of it (reusing to merge a PR with it).

@flip1995 flip1995 added has-merge-commits PR has merge commits, merge with caution. and removed has-merge-commits PR has merge commits, merge with caution. labels Sep 18, 2023
@flip1995
Copy link
Member

Thanks! I added the label (copied from rust repo, same color and everything)

Will this PR work before merging the triagebot PR or will it break triagebot? r=me once the triagebot PR is merge or if this already works without that PR @bors delegate+

@bors
Copy link
Contributor

bors commented Sep 18, 2023

✌️ @pitaj, you can now approve this pull request!

If @flip1995 told you to "r=me" after making some further change, please make that change, then do @bors r=@flip1995

@pitaj
Copy link
Contributor Author

pitaj commented Sep 18, 2023

It technically won't break anything but I'll wait until the triagebot change is merged.

@pitaj
Copy link
Contributor Author

pitaj commented Oct 16, 2023

Triagebot PR was merged

@bors r=@flip1995

@bors
Copy link
Contributor

bors commented Oct 16, 2023

📌 Commit 6e0c456 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 16, 2023

⌛ Testing commit 6e0c456 with merge ae52ee5...

@bors
Copy link
Contributor

bors commented Oct 16, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing ae52ee5 to master...

@bors bors merged commit ae52ee5 into rust-lang:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants