Migrate generate_trait_from_impl assist to use SyntaxEditor
#20371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67815bf to
fa03efa
Compare
Veykril
reviewed
Aug 3, 2025
crates/syntax/src/ast/make.rs
Outdated
| @@ -1020,7 +1020,7 @@ pub fn trait_( | |||
| ident: &str, | |||
| gen_params: Option<ast::GenericParamList>, | |||
| where_clause: Option<ast::WhereClause>, | |||
| assoc_items: ast::AssocItemList, | |||
| assoc_items: Option<ast::AssocItemList>, | |||
There was a problem hiding this comment.
This being non-optional sounds correct to me as it would be an invalid trait definition otherwise (ignoring the trait alias feature for now). It should be fine to just unwrap the cast in the assist above, as should that fail that's a bug in SyntaxEditor (correct me if I am wrong, I am not too familiar with this API)
There was a problem hiding this comment.
I see. That sounds correct.
fa03efa to
24f7f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #15710 and #18285