Skip to content

add SyntaxEditor::delete_all to migrate utils.rs add_trait_assoc_items_to_impl #20345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

add SyntaxEditor::delete_all to migrate utils.rs add_trait_assoc_items_to_impl #20345

merged 1 commit into from
Jul 31, 2025

Conversation

Hmikihiro
Copy link
Contributor

@Hmikihiro Hmikihiro commented Jul 30, 2025 •
edited
Loading

part of #15710 and #18285

I add delete_all instead of ted::remove_all.

delete_all was called from syntax_editor/edit.rs ast::TypeBoundList{ fn remove} like as ted::remove_all in ast::TypeBoundList{ fn remove} of edit_in_place.rs

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2025
ShoyuVanilla
ShoyuVanilla approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Jul 31, 2025
Merged via the queue into rust-lang:master with commit 68e7ec9 Jul 31, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hmikihiro @ShoyuVanilla @rustbot