Skip to content

Revert "Re-enable fixpoint iteration for variance computation" #20200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Revert "Re-enable fixpoint iteration for variance computation" #20200

merged 1 commit into from
Jul 9, 2025

Conversation

ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Jul 8, 2025 •
edited by rustbot
Loading

Reverts #20157.

Variance still causes problems.

Fixes #20199.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 8, 2025
@ChayimFriedman2 ChayimFriedman2 mentioned this pull request Jul 8, 2025
Closed
ShoyuVanilla
ShoyuVanilla approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'm a right person to review this but merging anyway since Lukas is on a vacation starting from today and this is obviously a revert PR 😄

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Jul 9, 2025
Merged via the queue into master with commit e429bac Jul 9, 2025
15 checks passed
@ShoyuVanilla ShoyuVanilla deleted the revert-20157-push-nxrvpywtvoys branch July 9, 2025 02:42
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2025
@ShoyuVanilla ShoyuVanilla mentioned this pull request Jul 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust analyzer hangs processing function using oxc.
3 participants
@ChayimFriedman2 @ShoyuVanilla @rustbot