-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ci: Fix cancel parallel jobs on windows #20084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4345a52
to
6ab76a8
Compare
I think we can run |
0f63b6d
to
ef4ddda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just change the shell for windows to bash? https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#defaultsrunshell
ef4ddda
to
be7f564
Compare
I was going to do this in a breeze but Okay, I'll try with |
be7f564
to
4ed9bfc
Compare
Oh, this worked well. I should have tried bash first 😂 |
4ed9bfc
to
dfd2c0e
Compare
So the following was my chain of thoughts:
Thus, I just try to do things with What I lacked of were faith to belive Windows runner and determination to try brand new alternative on my first fail 😅 |
Welp, I knew about bash on Windows but lately I'm a little too biased against changing the defaults. But I just realized we couldn't have kept a single step if we ran |
Yes, might be hard to correctly locate https://github.com/rust-lang/rust-analyzer/actions/runs/15852059976/job/44687827150 Besides those exit code behaviors (might be) related to HTTP status code, I have no idea why GitHub returns |
Fixes #20079