feat: Add Config Option to Exclude Locals from Document Symbol Search #20420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChayimFriedman2
requested changes
Aug 10, 2025
417d42d to
bf4a38a
Compare
ChayimFriedman2
requested changes
Aug 10, 2025
bf4a38a to
51a89d6
Compare
|
Hey, @ChayimFriedman2, on my latest push, the CI check error: this expression creates a reference which is immediately dereferenced by the compiler
Error: --> crates/ide/src/file_structure.rs:277:47
|
277 | let structure = file_structure(&file, &config);
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
error: could not compile `ide` (lib test) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.But this check is not run by Edit: This code that failed was located under a Edit: When I added a needless borrow in a non test module, |
51a89d6 to
0a4d7dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new workspace configuration option to exclude local variables from Document Symbol Search.
Addresses #20403.