Add AsRef and Borrow for generate_mut_trait_impl #19917

A4-Tacks · 2025-06-04T02:16:27Z

AsRef -> AsMut
Borrow -> BorrowMut

Example

//- minicore: as_ref
struct Foo(i32);

impl core::convert::AsRef$0<i32> for Foo {
    fn as_ref(&self) -> &i32 {
        &self.0
    }
}

->

struct Foo(i32);

$0impl core::convert::AsMut<i32> for Foo {
    fn as_mut(&mut self) -> &mut i32 {
        &self.0
    }
}

impl core::convert::AsRef<i32> for Foo {
    fn as_ref(&self) -> &i32 {
        &self.0
    }
}

ShoyuVanilla · 2025-06-27T09:17:40Z

crates/ide-assists/src/handlers/generate_mut_trait_impl.rs

        target,
        |edit| {
            edit.insert(target.start(), format!("$0{impl_def}\n\n{indent}"));
        },
    )
 }

+fn get_famous(apply_trait: &str, famous: FamousDefs<'_, '_>) -> Option<hir::Trait> {


I think this should be receive hir::Trait though it's currently using &str before this PR.
Like here:

rust-analyzer/crates/ide-assists/src/handlers/convert_into_to_from.rs

Lines 35 to 44 in 5b852da

let impl_ = ctx.find_node_at_offset::<ast::Impl>()?;

let src_type = impl_.self_ty()?;

let ast_trait = impl_.trait_()?;

let module = ctx.sema.scope(impl_.syntax())?.module();

let trait_ = resolve_target_trait(&ctx.sema, &impl_)?;

if trait_ != FamousDefs(&ctx.sema, module.krate()).core_convert_Into()? {

return None;

}

crates/ide-assists/src/handlers/generate_mut_trait_impl.rs

- AsRef -> AsMut - Borrow -> BorrowMut Example ==================== ```rust //- minicore: as_ref struct Foo(i32); impl<T> core::convert::AsRef$0<i32> for Foo { fn as_ref(&self) -> &i32 { &self.0 } } ``` -> ```rust struct Foo(i32); $0impl<T> core::convert::AsMut<i32> for Foo { fn as_mut(&mut self) -> &mut i32 { &self.0 } } impl<T> core::convert::AsRef<i32> for Foo { fn as_ref(&self) -> &i32 { &self.0 } } ```

ShoyuVanilla

I think there's still room for improvement here like:

We want to replace ted::* API with SyntaxEditor ones
When making implementations for BorrowMut, it might emit nameres error because we don't import it automatically. In fact, this is same for pre-existing IndexMut 😅

But anyway, I think this is an improvement over the current assist. Thanks!

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2025

ShoyuVanilla reviewed Jun 27, 2025

View reviewed changes

crates/ide-assists/src/handlers/generate_mut_trait_impl.rs Outdated Show resolved Hide resolved

A4-Tacks added 3 commits July 16, 2025 17:16

Remove redundant type parameters

28f1e62

Use hir::Trait in parameter

fc5dd8b

A4-Tacks force-pushed the ext-generate-mut branch from 875c1a3 to fc5dd8b Compare July 16, 2025 11:53

A4-Tacks requested a review from ShoyuVanilla July 16, 2025 12:11

ShoyuVanilla approved these changes Jul 16, 2025

View reviewed changes

ShoyuVanilla added this pull request to the merge queue Jul 16, 2025

Merged via the queue into rust-lang:master with commit 3c9ce17 Jul 16, 2025
15 checks passed

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2025

A4-Tacks deleted the ext-generate-mut branch July 16, 2025 16:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add AsRef and Borrow for generate_mut_trait_impl #19917

Add AsRef and Borrow for generate_mut_trait_impl #19917

Uh oh!

A4-Tacks commented Jun 4, 2025 •

edited

Loading

Uh oh!

ShoyuVanilla Jun 27, 2025

Uh oh!

Uh oh!

ShoyuVanilla left a comment

Uh oh!

Uh oh!

Uh oh!

	let impl_ = ctx.find_node_at_offset::<ast::Impl>()?;
	let src_type = impl_.self_ty()?;
	let ast_trait = impl_.trait_()?;

	let module = ctx.sema.scope(impl_.syntax())?.module();

	let trait_ = resolve_target_trait(&ctx.sema, &impl_)?;
	if trait_ != FamousDefs(&ctx.sema, module.krate()).core_convert_Into()? {
	return None;
	}

Add AsRef and Borrow for generate_mut_trait_impl #19917

Add AsRef and Borrow for generate_mut_trait_impl #19917

Uh oh!

Conversation

A4-Tacks commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Example

Uh oh!

ShoyuVanilla Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ShoyuVanilla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

A4-Tacks commented Jun 4, 2025 •

edited

Loading