Skip to content

internal: Fix CI running analysis-stats incorrectly against the standard libraries #18328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2024
Merged

internal: Fix CI running analysis-stats incorrectly against the standard libraries #18328

merged 1 commit into from
Oct 18, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Oct 18, 2024

Fixes #18326

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2024
@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Oct 18, 2024

📌 Commit a652165 has been approved by Veykril

It is now in the queue for this repository.

@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

@bors r-

@Veykril Veykril force-pushed the veykril/push-zrzmmyqzqwyr branch from a652165 to 705f9ef Compare October 18, 2024 08:58
@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Oct 18, 2024

📌 Commit 705f9ef has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 18, 2024

⌛ Testing commit 705f9ef with merge e416842...

bors added a commit that referenced this pull request Oct 18, 2024
@bors
Auto merge of #18328 - Veykril:veykril/push-zrzmmyqzqwyr, r=
e416842 
fix: Fix CI running analysis-stats incorrectly against the standard libraries

Fixes #18326
@bors
Copy link
Contributor

bors commented Oct 18, 2024

💔 Test failed - checks-actions

@ShoyuVanilla
Copy link
Member 

thread 'main' panicked at crates/hir-ty/src/infer/cast.rs:423:13:
internal error: entered unreachable code: `[Int(I8); Bytes([32, 0, 0, 0, 0, 0, 0, 0], Empty)]` should be sized but is not?

It seems that we are not getting Sized trait from lang items 🤔

@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

Yes, we set the test cfg which causes core to be empty hence no lang items

@Veykril Veykril force-pushed the veykril/push-zrzmmyqzqwyr branch from 705f9ef to 7703f1d Compare October 18, 2024 09:55
@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

Ugh, now its stuck in const eval somewhere

@Veykril Veykril force-pushed the veykril/push-zrzmmyqzqwyr branch from 7703f1d to 6ab96cd Compare October 18, 2024 10:21
@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

Okay now it should work
@bors r+

@bors
Copy link
Contributor

bors commented Oct 18, 2024

📌 Commit 6ab96cd has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 18, 2024

⌛ Testing commit 6ab96cd with merge efb7ea4...

bors added a commit that referenced this pull request Oct 18, 2024
@bors
Auto merge of #18328 - Veykril:veykril/push-zrzmmyqzqwyr, r=Veykril
efb7ea4 
fix: Fix CI running analysis-stats incorrectly against the standard libraries

Fixes #18326
Veykril
Veykril commented Oct 18, 2024
View reviewed changes
crates/rust-analyzer/src/cli/analysis_stats.rs Outdated
Comment on lines 64 to 65
cfg_overrides.global =
CfgDiff::new(vec![CfgAtom::Flag(hir::sym::miri.clone())], vec![]).unwrap();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should be a default for the cli commands

@Veykril Veykril force-pushed the veykril/push-zrzmmyqzqwyr branch from 6ab96cd to e5af3ae Compare October 18, 2024 10:35
@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

Clippy always has the last word
@bors r+

@bors
Copy link
Contributor

bors commented Oct 18, 2024

📌 Commit e5af3ae has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 18, 2024

⌛ Testing commit e5af3ae with merge 6703d7a...

@bors
Copy link
Contributor

bors commented Oct 18, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 6703d7a to master...

@bors bors merged commit 6703d7a into rust-lang:master Oct 18, 2024
11 checks passed
@Veykril Veykril deleted the veykril/push-zrzmmyqzqwyr branch October 18, 2024 10:54
@lnicola lnicola changed the title fix: Fix CI running analysis-stats incorrectly against the standard libraries internal: Fix CI running analysis-stats incorrectly against the standard libraries Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rust-analyzer analysis hangs up while mir building/evaluating in the standard library
4 participants
@Veykril @bors @ShoyuVanilla @rustbot