internal: fix lldb-dap unconditionally calling rustc #18320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Oct 17, 2024
lnicola
reviewed
Oct 17, 2024
| @@ -189,11 +203,15 @@ async function getDebugConfiguration( | |||
| return debugConfig; | |||
| } | |||
|
|
|||
| type SourceFileMap = { | |||
| source: string; | |||
| destination: string; | |||
There was a problem hiding this comment.
Nit: maybe target, but don't bother changing it.
lnicola
approved these changes
Oct 17, 2024
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Oct 17, 2024
…ustc, r=davidbarsky internal: fix lldb-dap unconditionally calling rustc Fixes #18318. I also took the opportunity to refactor how `discoverSourceFileMap` worked—it now returns a type instead of mutating a map in place. I tested this change using the LLDB DAP extension. I needed to set `"lldb-dap.executable-path": "/Applications/Xcode.app/Contents/Developer/usr/bin/lldb-dap"` for everything to work, however, but once I did, was able to successfully debug a test.
|
@bors retry |
bors
added a commit
that referenced
this pull request
Oct 17, 2024
…ustc, r=davidbarsky internal: fix lldb-dap unconditionally calling rustc Fixes #18318. I also took the opportunity to refactor how `discoverSourceFileMap` worked—it now returns a type instead of mutating a map in place. I tested this change using the LLDB DAP extension. I needed to set `"lldb-dap.executable-path": "/Applications/Xcode.app/Contents/Developer/usr/bin/lldb-dap"` for everything to work, however, but once I did, was able to successfully debug a test.
|
💥 Test timed out |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Oct 17, 2024
…ustc, r=davidbarsky internal: fix lldb-dap unconditionally calling rustc Fixes #18318. I also took the opportunity to refactor how `discoverSourceFileMap` worked—it now returns a type instead of mutating a map in place. I tested this change using the LLDB DAP extension. I needed to set `"lldb-dap.executable-path": "/Applications/Xcode.app/Contents/Developer/usr/bin/lldb-dap"` for everything to work, however, but once I did, was able to successfully debug a test.
|
💥 Test timed out |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Oct 18, 2024
…ustc, r=davidbarsky internal: fix lldb-dap unconditionally calling rustc Fixes #18318. I also took the opportunity to refactor how `discoverSourceFileMap` worked—it now returns a type instead of mutating a map in place. I tested this change using the LLDB DAP extension. I needed to set `"lldb-dap.executable-path": "/Applications/Xcode.app/Contents/Developer/usr/bin/lldb-dap"` for everything to work, however, but once I did, was able to successfully debug a test.
|
💔 Test failed - checks-actions |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18318. I also took the opportunity to refactor how
discoverSourceFileMapworked—it now returns a type instead of mutating a map in place.I tested this change using the LLDB DAP extension. I needed to set
"lldb-dap.executable-path": "/Applications/Xcode.app/Contents/Developer/usr/bin/lldb-dap"for everything to work, however, but once I did, was able to successfully debug a test.