Skip to content

internal: add typos check CI (part 2) #16469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 2, 2024
Merged

internal: add typos check CI (part 2) #16469

merged 5 commits into from
Feb 2, 2024

Conversation

Young-Flash
Copy link
Member

follow up #16448

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 1, 2024
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 1, 2024
View reviewed changes
Nadrieril
Nadrieril reviewed Feb 1, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 2, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 2, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 2, 2024
View reviewed changes
.typos.toml Outdated
datas = "datas"
impl_froms = "impl_froms"
selfs = "selfs"
strustS = "strustS"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be structS, but the whole test hurts my brain:

image

lnicola
lnicola reviewed Feb 2, 2024
View reviewed changes
lnicola
lnicola reviewed Feb 2, 2024
View reviewed changes
@Young-Flash Young-Flash force-pushed the ci_typos branch 2 times, most recently from 7419e09 to 68fad23 Compare February 2, 2024 10:31
@lnicola
Copy link
Member

lnicola commented Feb 2, 2024

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 2, 2024

📌 Commit a52a4d9 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 2, 2024

⌛ Testing commit a52a4d9 with merge 8f6a728...

@bors
Copy link
Contributor

bors commented Feb 2, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 8f6a728 to master...

@bors bors merged commit 8f6a728 into rust-lang:master Feb 2, 2024
@Young-Flash Young-Flash deleted the ci_typos branch February 2, 2024 12:38
This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
This was referenced May 28, 2024
Merged
Closed
Closed
Closed
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 4, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 18, 2024
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

+1 more reviewer

@Nadrieril Nadrieril Nadrieril left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Young-Flash @lnicola @bors @Nadrieril @rustbot