Use TraitEngine in more places that don't specifically need FulfillmentContext::new_in_snapshot
#99746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
…ntCtxt::new_in_snapshot
aa4c5d9 to
58f107a
Compare
|
side note: I can't check how this affects chalk migrate-mode tests b/c some of them hang forever, lol. |
|
re-rolling for spastorino r? types |
|
@bors r+ |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 3, 2022
…r=jackh726 Use `TraitEngine` in more places that don't specifically need `FulfillmentContext::new_in_snapshot` Not sure if this change is worthwhile, but couldn't hurt re: chalkification r? types
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#98771 (Add support for link-flavor rust-lld for iOS, tvOS and watchOS) - rust-lang#98835 (relate `closure_substs.parent_substs()` to parent fn in NLL) - rust-lang#99746 (Use `TraitEngine` in more places that don't specifically need `FulfillmentContext::new_in_snapshot`) - rust-lang#99786 (Recover from C++ style `enum struct`) - rust-lang#99795 (Delay a bug when failed to normalize trait ref during specialization) - rust-lang#100029 (Prevent ICE for `doc_alias` on match arm, statement, expression) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 10, 2022
…wesleywiser Use `TraitEngine` in more places, restrict visibility of `FulfillmentCtxt` constructor Most places that are constructing a `FulfillmentContext` should be constructing a `TraitEngine` generically, so later on if/when we're transitioning it'll be easier. Logical extension of rust-lang#99746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this change is worthwhile, but couldn't hurt re: chalkification
r? types