Skip to content

diagnostics: add test case for bogus T:Sized suggestion #95593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2022
Merged

diagnostics: add test case for bogus T:Sized suggestion #95593

merged 1 commit into from
Apr 2, 2022

Conversation

notriddle
Copy link
Contributor

Closes #69228

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 2, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 2, 2022
@compiler-errors
Copy link
Member

r? @compiler-errors
@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Apr 2, 2022

📌 Commit 7620a5f has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2022
@bors
Auto merge of rust-lang#95600 - Dylan-DPC:rollup-580y2ra, r=Dylan-DPC
76d770a 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#95587 (Remove need for associated_type_bounds in std.)
 - rust-lang#95589 (Include a header in .rlink files)
 - rust-lang#95593 (diagnostics: add test case for bogus T:Sized suggestion)
 - rust-lang#95597 (Refer to u8 by absolute path in expansion of thread_local)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 348e77c into rust-lang:master Apr 2, 2022
@rustbot rustbot added this to the 1.61.0 milestone Apr 2, 2022
@notriddle notriddle deleted the notriddle/size-of-in-const-context branch April 3, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

Bogus T:Sized suggestion when using size_of::<T> as a const
6 participants
@notriddle @rust-highfive @compiler-errors @bors @Mark-Simulacrum @rustbot