Skip to content

diagnostics: regression test for derive bounds #95437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2022
Merged

diagnostics: regression test for derive bounds #95437

merged 1 commit into from
Mar 29, 2022

Conversation

notriddle
Copy link
Contributor

Closes #79076

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 29, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2022
@notriddle notriddle force-pushed the notriddle/issue-79076 branch from c703231 to 81bb958 Compare March 29, 2022 17:18
@notriddle notriddle force-pushed the notriddle/issue-79076 branch from 81bb958 to 0eea334 Compare March 29, 2022 17:19
@compiler-errors
Copy link
Member

This was fixed somewhere between 1.58 and 1.59 -- I wonder what exact PR. @notriddle, do you know, just for bookkeeping? If not, then no biggie. Anyways, looks good to me.

r? @compiler-errors
@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Mar 29, 2022

📌 Commit 0eea334 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2022
@bors
Auto merge of rust-lang#95448 - Dylan-DPC:rollup-wpj5yto, r=Dylan-DPC
9c06e1b 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#93840 (Stabilize Termination and ExitCode)
 - rust-lang#95256 (Ensure io::Error's bitpacked repr doesn't accidentally impl UnwindSafe)
 - rust-lang#95386 (Suggest wrapping patterns in enum variants)
 - rust-lang#95437 (diagnostics: regression test for derive bounds)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2471502 into rust-lang:master Mar 29, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 29, 2022
@notriddle notriddle deleted the notriddle/issue-79076 branch March 30, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

Compiler suggests #[derive(Clone, Eq + Clone)]
6 participants
@notriddle @rust-highfive @compiler-errors @bors @Mark-Simulacrum @rustbot