Resolve lifetimes for const generic defaults #93669
Merged
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
|
can you add a test for struct Foo<'a, const N: usize = {
let x: &'a ();
3
}>(&'a ());completely missed lifetimes in const param defaults, this should error. after that r=me, thanks |
|
missed lifetimes in const parameter defaults, which are currently stable on |
|
r? @lcnr |
ede78b2 to
bcf9884
Compare
|
done. this catches that too, since the logic of detecting non- |
compiler-errors
commented
Feb 5, 2022
| @@ -0,0 +1,10 @@ | |||
| struct Foo< | |||
| 'a, | |||
There was a problem hiding this comment.
haha rustfmt is so weird, i swear i didn't do this
|
thanks for the fix ❤️ @bors r+ rollup |
|
📌 Commit bcf9884 has been approved by |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 5, 2022
… r=lcnr Resolve lifetimes for const generic defaults We weren't visiting the const generic default argument in `rustc_resolve::late::lifetimes`. This seems to fix the issue, and we deny any non-`'static` lifetimes anyways. Fixes rust-lang#93647
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 6, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#91939 (Clarify error on casting larger integers to char) - rust-lang#92300 (mips64-openwrt-linux-musl: Add Tier 3 target) - rust-lang#92383 (Add new target armv7-unknown-linux-uclibceabi (softfloat)) - rust-lang#92651 (Remove "up here" arrow on item-infos) - rust-lang#93556 (Change struct expr pretty printing to match rustfmt style) - rust-lang#93649 (Add regression tests for issue 80309) - rust-lang#93657 (Update CPU idle tracking for apple hosts) - rust-lang#93659 (Refactor conditional) - rust-lang#93669 (Resolve lifetimes for const generic defaults) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Alexendoo
added a commit
to rust-lang/glacier
that referenced
this pull request
Feb 7, 2022
That was fixed separately by rust-lang/rust#93669 Closes #1109
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 8, 2022
…thewjasper update comment wrt const param defaults after rust-lang#93669 i looked through all other uses of `GenericParamKind::Const` again to detect if we missed the `default` there as well, but afaict we really only missed lifetime resolution '^^ at least i found an outdated comment :3
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 12, 2022
…ulacrum [beta] backports This backports: * Complete removal of #[main] attribute from compiler rust-lang#93753 * Resolve lifetimes for const generic defaults rust-lang#93669 * backport llvm fix for issue 91671. rust-lang#93426 * Fix invalid special casing of the unreachable! macro rust-lang#93179 * Fix hashing for windows paths containing a CurDir component rust-lang#93697 r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't visiting the const generic default argument in
rustc_resolve::late::lifetimes. This seems to fix the issue, and we deny any non-'staticlifetimes anyways.Fixes #93647