Skip to content

Fix toggle-click-deadspace rustdoc-gui test #91171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2021
Merged

Fix toggle-click-deadspace rustdoc-gui test #91171

merged 1 commit into from
Nov 24, 2021

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Nov 24, 2021

In #91103 I introduced a rustdoc-gui test for clicks on toggles. I introduced some documentation on a method in lib2/struct.Foo.html so there would be something to toggle, but accidentally left the test checking test_docs/struct.Foo.html. That caused the test to reliably fail.

I'm not sure how that test got past GitHub Actions and bors, but it's manifesting in test failures at #91062 (comment) and #91170 (comment).

This fixes by pointing at the right file.

r? @GuillaumeGomez

@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Nov 24, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2021
@GuillaumeGomez
Copy link
Member

Considering it's breaking the CI, setting a slightly higher priority.

@bors: r+ p=1

@bors
Copy link
Collaborator

bors commented Nov 24, 2021

📌 Commit 420be4a has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2021
@bors
Copy link
Collaborator

bors commented Nov 24, 2021

⌛ Testing commit 420be4a with merge 982c552...

@bors
Copy link
Collaborator

bors commented Nov 24, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 982c552 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 24, 2021
@bors bors merged commit 982c552 into rust-lang:master Nov 24, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 24, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (982c552): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -5.8% on incr-unchanged builds of inflate)
  • Large regression in instruction counts (up to 4.1% on incr-unchanged builds of deep-vector)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Nov 24, 2021
@GuillaumeGomez
Copy link
Member

Euh. What? Why are there perf changes in here? XD

@jyn514 jyn514 mentioned this pull request Nov 24, 2021
Merged
@Mark-Simulacrum Mark-Simulacrum removed the perf-regression Performance regression. label Nov 30, 2021
@Mark-Simulacrum
Copy link
Member

cc rust-lang/rustc-perf#1105, spurious change, dropping regression label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jsha @GuillaumeGomez @bors @rust-timer @Mark-Simulacrum @rust-highfive @rustbot