Skip to content

fix(rustc_lint): better detect when parens are necessary #91956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2021
Merged

fix(rustc_lint): better detect when parens are necessary #91956

merged 2 commits into from
Dec 19, 2021

Conversation

notriddle
Copy link
Contributor

Fixes #90807

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 15, 2021
@rust-highfive
Copy link
Contributor

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@notriddle notriddle force-pushed the notriddle/unused-parens-range branch from 9a9c077 to 6b1a96e Compare December 15, 2021 06:47
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@notriddle notriddle force-pushed the notriddle/unused-parens-range branch from 6b1a96e to 6b7fcf7 Compare December 15, 2021 07:00
nagisa
nagisa reviewed Dec 17, 2021
View reviewed changes
@nagisa nagisa added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2021
@notriddle
Copy link
Contributor Author

@rustbot label: -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 17, 2021
@nagisa
Copy link
Member

nagisa commented Dec 18, 2021

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Dec 18, 2021

📌 Commit f4a0321 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 18, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2021
@bors
Auto merge of rust-lang#92090 - matthiaskrgr:rollup-pbyqddi, r=matthi…
df2f45c 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91834 (Update browser-ui-test version and improve rustdoc-gui tests readability)
 - rust-lang#91894 (Remove `in_band_lifetimes` from `rustc_incremental`)
 - rust-lang#91932 (Add user seed to `-Z randomize-layout`)
 - rust-lang#91956 (fix(rustc_lint): better detect when parens are necessary)
 - rust-lang#92020 (Remove P: Unpin bound on impl Stream for Pin)
 - rust-lang#92063 (docs: fix typo)
 - rust-lang#92082 (rustdoc: Write doc-comments directly instead of using FromIterator)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4891531 into rust-lang:master Dec 19, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 19, 2021
@notriddle notriddle deleted the notriddle/unused-parens-range branch December 19, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagisa nagisa nagisa left review comments

Assignees

@nagisa nagisa

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

unused_parens false positive for parenthesised Range in for loop
6 participants
@notriddle @rust-highfive @rust-log-analyzer @nagisa @bors @rustbot