Skip to content

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Jun 24, 2021

PR #86561 removes the only place the generics member is read. This PR does even more cleanup.

Commit e629381 removes the only place
these members variables are actually read.
@rust-highfive
Copy link
Contributor

r? @ollie27

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2021
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome ❤️

@jyn514
Copy link
Member

jyn514 commented Jun 25, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 25, 2021

📌 Commit 14ca894 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2021
@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 25, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 25, 2021
…, r=jyn514

chore(rustdoc): remove unused members of RenderType

PR rust-lang#86561 removes the only place the `generics` member is read. This PR does even more cleanup.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 25, 2021
Rollup of 5 pull requests

Successful merges:

 - rust-lang#86330 (Change how edition based future compatibility warnings are handled)
 - rust-lang#86513 (Rustdoc: Do not list impl when trait has doc(hidden))
 - rust-lang#86592 (Use `#[non_exhaustive]` where appropriate)
 - rust-lang#86608 (chore(rustdoc): remove unused members of RenderType)
 - rust-lang#86624 (Update compiler-builtins)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit daa87ad into rust-lang:master Jun 25, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 25, 2021
@notriddle notriddle deleted the notriddle/cleanup-rustdoc branch June 25, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants