Only enable assert_dep_graph when query-dep-graph is enabled. #83313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @cjgillot! We still need to solve the problem with incr. comp. tests. If we merge this in the current form, any incr. comp. test that forgets to explicitly add What's a good way to avoid that? |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Nice -- thank you, @cjgillot!
r=me with that stray comment fixed.
| @@ -1012,6 +1018,19 @@ impl CheckAttrVisitor<'tcx> { | |||
| } | |||
| } | |||
|
|
|||
| /// Checks if `#[rustc_legacy_const_generics]` is applied to a function and has a valid argument. | |||
There was a problem hiding this comment.
This comment seems to be out of place.
|
@bors r=michaelwoerister |
|
📌 Commit 2ce044a218350fee21691ee7689838a0bcd6093b has been approved by |
|
@bors r=michaelwoerister |
|
📌 Commit 31447f6 has been approved by |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 23, 2021
Only enable assert_dep_graph when query-dep-graph is enabled. This is a debugging option. The only effect should be on rustc tests. r? `@michaelwoerister`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 23, 2021
Only enable assert_dep_graph when query-dep-graph is enabled. This is a debugging option. The only effect should be on rustc tests. r? `@michaelwoerister`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 24, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#83051 (Sidebar trait items order) - rust-lang#83313 (Only enable assert_dep_graph when query-dep-graph is enabled.) - rust-lang#83353 (Add internal io::Error::new_const to avoid allocations.) - rust-lang#83391 (Allow not emitting `uwtable` on Android) - rust-lang#83392 (Change `-W help` to display edition level.) - rust-lang#83393 (Codeblock tooltip position) - rust-lang#83399 (rustdoc: Record crate name instead of using `None`) - rust-lang#83405 (Slight visual improvements to warning boxes in the docs) - rust-lang#83415 (Remove unnecessary `Option` wrapping around `Crate.module`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a debugging option. The only effect should be on rustc tests.
r? @michaelwoerister