Skip to content

Conversation

RalfJung
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

kper and others added 17 commits May 3, 2020 11:00
This stabilizes process_set_argv0 targeting 1.45.0. It has been
useful in practice and seems useful as-is.

The equivalent feature could be implemented for Windows, but as far as I
know nobody has. That can be done separately.

Tracking issue: rust-lang#66510
Fix suggestion to borrow in struct

The corresponding issue is rust-lang#71136.
The compiler suggests that borrowing `the_foos` might solve the problem. This is obviously incorrect.
```
struct Foo(u8);

#[derive(Clone)]
struct FooHolster {
    the_foos: Vec<Foo>,
}
```

I propose as fix to check if there is any colon in the span. However, there might a case where `my_method(B { a: 1, b : foo })` would be appropriate to show a suggestion for `&B ...`.  To fix that too, we can simply check if there is a bracket in the span. This is only possible because both spans are different.
Issue's span: `the_foos: Vec<Foo>`
other's span: `B { a : 1, b : foo }`
Stabilize process_set_argv0 feature for Unix

This stabilizes process_set_argv0 targeting 1.45.0. It has been
useful in practice and seems useful as-is.

The equivalent feature could be implemented for Windows, but as far as I
know nobody has. That can be done separately.

Tracking issue: rust-lang#66510
…-Simulacrum

[self-profling] Record the cgu name when doing codegen for a module
Add fast-path optimization for Ipv4Addr::fmt

Don't use an intermediary buffer when writing an IPv4 address without any specific alignment options
…Simulacrum

rustllvm: Fix warnings about unused function parameters

And then perform corresponding cleanups on Rust side.

Fixes rust-lang#72427
@RalfJung
Copy link
Member Author

@rustbot modify labels: +rollup
@bors r+ rollup=never p=7

@bors
Copy link
Collaborator

bors commented May 22, 2020

📌 Commit e7503ca has been approved by RalfJung

@rustbot rustbot added the rollup A PR which is a rollup label May 22, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 22, 2020
@bors
Copy link
Collaborator

bors commented May 22, 2020

⌛ Testing commit e7503ca with merge 215f2d3...

@bors
Copy link
Collaborator

bors commented May 22, 2020

☀️ Test successful - checks-azure
Approved by: RalfJung
Pushing 215f2d3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 22, 2020
@bors bors merged commit 215f2d3 into rust-lang:master May 22, 2020
@RalfJung RalfJung deleted the rollup-xhm7w7u branch May 23, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants