Skip to content

Remove experimental chalk option #69247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2020
Merged

Remove experimental chalk option #69247

merged 1 commit into from
Mar 3, 2020

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Feb 17, 2020

As suggested by @nikomatsakis here.

The current version of chalk used by the experimental -Zchalk flag is v0.9.0, which is over a year old. Since v0.9.0, chalk has seen a lot of further development, and the intent is to eventually upgrade rustc to use a more recent chalk.

However, it will take a decent chunk of effort to upgrade the current experimental chalk support, and it is currently blocking at least some PRs due to chalk:0.9.0's use of unstable features. So for the interim until the next chalk release and experimental rustc integration, we remove the chalk-specific code from rustc.

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2020
@jackh726
Copy link
Member

jackh726 commented Feb 17, 2020 •
edited
Loading

FWIW, I've gotten (locally) the Chalk-related code updated to the latest Chalk master (with some modifications that'll get PRed soon). It compiles but -Z chalk tests are broken.

@CAD97
Copy link
Contributor Author

CAD97 commented Feb 18, 2020

Just for good measure, I suppose I should cc @rust-lang/wg-traits

@cramertj
Copy link
Member

r? @nikomatsakis

@bors
Copy link
Collaborator

bors commented Feb 22, 2020

☔ The latest upstream changes (presumably #69242) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2020
@nikomatsakis
Copy link
Contributor

OK so I talked to @jackh726 and we agreed that we could go ahead and land this, we'll just "git revert" it and build our replacement. I did a review and it looks good, but it needs a rebase.

@bors delegate=CAD97

@CAD97 if you want to rebase, you can go ahead and make it r=nikomatsakis afterwards.

@bors
Copy link
Collaborator

bors commented Mar 2, 2020

✌️ @CAD97 can now approve this pull request

@CAD97
Copy link
Contributor Author

CAD97 commented Mar 2, 2020

Rebased. If only GitHub actually had a way to show just the conflict resolution of the rebase...

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented Mar 2, 2020

📌 Commit 02b872ed51d74eb48b07e5dd7b15d51636bf7e76 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 2, 2020
@CAD97
Copy link
Contributor Author

CAD97 commented Mar 2, 2020 •
edited
Loading

@bors r-

Tidy failures crept into the rebase; investigating

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2020
@CAD97
Copy link
Contributor Author

CAD97 commented Mar 2, 2020

@bors: r=nikomatsakis

I missed a trailing newline, that's it.

@bors
Copy link
Collaborator

bors commented Mar 2, 2020

📌 Commit b3777c9 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 2, 2020
@CAD97 CAD97 mentioned this pull request Mar 3, 2020
Merged
@bors
Copy link
Collaborator

bors commented Mar 3, 2020

⌛ Testing commit b3777c9 with merge 9381e81...

@bors
Copy link
Collaborator

bors commented Mar 3, 2020

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing 9381e81 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 3, 2020
@bors bors merged commit 9381e81 into rust-lang:master Mar 3, 2020
This was referenced Mar 3, 2020
Closed
Merged
Merged
@JohnTitor JohnTitor mentioned this pull request Mar 7, 2020
Merged
ehuss added a commit to ehuss/rust that referenced this pull request Mar 13, 2020
@ehuss
tidy: Remove chalk-engine/chalk-macros.
ed0158d 
Removed in rust-lang#69247 while this PR was waiting to merge.
@ehuss ehuss mentioned this pull request Mar 13, 2020
Merged
@jackh726 jackh726 mentioned this pull request May 7, 2020
Closed
@CAD97 CAD97 deleted the remove-chalk branch November 6, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CAD97 @rust-highfive @jackh726 @cramertj @bors @nikomatsakis @JohnCSimon