Skip to content

Conversation

msizanoen1
Copy link
Contributor

@msizanoen1 msizanoen1 commented Jan 9, 2020

This modifies dist-various-1 to build the standard library for RISC-V GNU/Linux.

r? @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2020
@msizanoen1 msizanoen1 changed the title CI for riscv64-unknown-linux-gnu Distribution CI for riscv64-unknown-linux-gnu Jan 9, 2020
@msizanoen1 msizanoen1 changed the title Distribution CI for riscv64-unknown-linux-gnu Distribution CI for riscv64gc-unknown-linux-gnu Jan 9, 2020
@msizanoen1
Copy link
Contributor Author

@rustbot modify labels: +O-riscv +O-linux +T-infra

@rustbot rustbot added O-linux Operating system: Linux O-riscv Target: RISC-V architecture T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 9, 2020
@alexcrichton
Copy link
Member

Thanks for the PR!

Unfortunately we don't have capacity to produce a whole new architecture of rustc right now, so we can add this in the repository under the disabled folder but we can't add it to CI right now.

@mati865
Copy link
Member

mati865 commented Jan 9, 2020

This PR provides only riscv64gc-unknown-linux-gnu target without host riscv64gc-unknown-linux-gnu toolchain.
Maybe it could be squished into one of dist-varsious builders? That would at least enable cross compilation to riscv64gc-unknown-linux-gnu target.

@alexcrichton
Copy link
Member

Ah oops I misunderstood! Yes folding this into one of the dist-various-* builders should be fine.

@msizanoen1 msizanoen1 force-pushed the riscv-ci branch 3 times, most recently from aa923c8 to 5959999 Compare January 10, 2020 05:36
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 10, 2020

📌 Commit 5959999 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2020
Centril added a commit to Centril/rust that referenced this pull request Jan 11, 2020
Distribution CI for riscv64gc-unknown-linux-gnu

This modifies `dist-various-1` to build the standard library for RISC-V GNU/Linux.

r? @alexcrichton
@Centril
Copy link
Contributor

Centril commented Jan 11, 2020

Failed in #68113, @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2020
@msizanoen1
Copy link
Contributor Author

It's fixed now.

@nagisa
Copy link
Member

nagisa commented Jan 11, 2020

@bors r=alexcrichton rollup=never

@bors
Copy link
Collaborator

bors commented Jan 11, 2020

📌 Commit 451c97b has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 11, 2020
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 15, 2020
@jonas-schievink jonas-schievink added this to the 1.42 milestone Jan 15, 2020
@bors
Copy link
Collaborator

bors commented Jan 18, 2020

⌛ Testing commit 451c97b with merge 1b117d7...

bors added a commit that referenced this pull request Jan 18, 2020
Distribution CI for riscv64gc-unknown-linux-gnu

This modifies `dist-various-1` to build the standard library for RISC-V GNU/Linux.

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Jan 18, 2020

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 1b117d7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 18, 2020
@bors bors merged commit 451c97b into rust-lang:master Jan 18, 2020
@msizanoen1 msizanoen1 deleted the riscv-ci branch January 18, 2020 11:37
msizanoen1 added a commit to msizanoen1/rust that referenced this pull request Jan 18, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 20, 2020
Add `riscv64gc-unknown-linux-gnu` into target list in build-manifest

Missed in rust-lang#68037

r? @alexcrichton
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 20, 2020
Add `riscv64gc-unknown-linux-gnu` into target list in build-manifest

Missed in rust-lang#68037

r? @alexcrichton
ehuss added a commit to ehuss/rust-forge that referenced this pull request May 15, 2020
The following targets are now built and distributed:

- aarch64-unknown-none: rust-lang/rust#68334
- mips64-unknown-linux-muslabi64: rust-lang/rust#65843
- mips64el-unknown-linux-muslabi64: rust-lang/rust#65843
- nvptx64-nvidia-cuda: rust-lang/rust#57937
- riscv32i-unknown-none-elf: rust-lang/rust#62784
- riscv64gc-unknown-linux-gnu: rust-lang/rust#68037
- thumbv8m.base-none-eabi: rust-lang/rust#59182
- thumbv8m.main-none-eabi : rust-lang/rust#56954
- thumbv8m.main-none-eabihf: rust-lang/rust#59182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-linux Operating system: Linux O-riscv Target: RISC-V architecture relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants