Skip to content

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Oct 17, 2019

Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1

Pretty low risk, considering the only changes are in low-tier targets.

r? @cramertj
cc @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2019
@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 17, 2019

📌 Commit db94656 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2019
@mati865
Copy link
Member

mati865 commented Oct 18, 2019

It will fail because of cc bump, see #65445

tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
Update backtrace to 0.3.40

Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1

Pretty low risk, considering the only changes are in low-tier targets.

r? @cramertj
cc @alexcrichton
@tmandry
Copy link
Member Author

tmandry commented Oct 18, 2019

@mati865 Thanks for pointing that out! @bors r- for now until we find a way to deal with this.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 18, 2019
@JohnCSimon
Copy link
Member

Ping from triage
@tmandry Can you please post the status of this PR?
cc: @cramertj

Thanks!

@mati865
Copy link
Member

mati865 commented Oct 26, 2019

@tmandry you can try using older cc crate, version 1.0.37 should be fine.

@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 28, 2019

📌 Commit d7f99da has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 29, 2019
Update backtrace to 0.3.40

Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1

Pretty low risk, considering the only changes are in low-tier targets.

r? @cramertj
cc @alexcrichton
Centril added a commit to Centril/rust that referenced this pull request Oct 29, 2019
Update backtrace to 0.3.40

Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1

Pretty low risk, considering the only changes are in low-tier targets.

r? @cramertj
cc @alexcrichton
Centril added a commit to Centril/rust that referenced this pull request Oct 29, 2019
Update backtrace to 0.3.40

Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1

Pretty low risk, considering the only changes are in low-tier targets.

r? @cramertj
cc @alexcrichton
bors added a commit that referenced this pull request Oct 29, 2019
Rollup of 5 pull requests

Successful merges:

 - #65294 (Lint ignored `#[inline]` on function prototypes)
 - #65318 (Call out the types that are non local on E0117)
 - #65531 (Update backtrace to 0.3.40)
 - #65562 (Improve the "try using a variant of the expected type" hint.)
 - #65809 (Add new EFIAPI ABI)

Failed merges:

r? @ghost
@bors bors merged commit d7f99da into rust-lang:master Oct 29, 2019
@tmandry tmandry deleted the bump-backtrace branch March 2, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants