rename Scalar::Bits to Scalar::Raw and bits field to data #61164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #59276) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me after rebase |
|
I decided to also refactor how we are doing the scalar sanity checks a bit. And I'd like to see how expensive these checks are. @bors try |
bors
added a commit
that referenced
this pull request
May 26, 2019
rename Scalar::Bits to Scalar::Raw and bits field to data Also use this opportunity to seal some abstraction leaks (other modules constructing `Scalar::Bits` directly instead of using a constructor). r? @oli-obk
|
Oh and I found a bug in the signed pointer offset code that could lead to those sanity checks failing. ;) |
oli-obk
reviewed
May 26, 2019
oli-obk
reviewed
May 26, 2019
Centril
reviewed
May 26, 2019
|
☀️ Try build successful - checks-travis |
|
@rust-timer build 2189421 |
|
Success: Queued 2189421 with parent 566f3d7, comparison URL. |
|
Finished benchmarking try commit 2189421: comparison url |
|
Timing looks much better than I expected! max <4%. I'll still demote some of these to |
|
Now with fewer assertions. @bors try |
bors
added a commit
that referenced
this pull request
May 26, 2019
rename Scalar::Bits to Scalar::Raw and bits field to data Also use this opportunity to seal some abstraction leaks (other modules constructing `Scalar::Bits` directly instead of using a constructor). r? @oli-obk
oli-obk
reviewed
May 26, 2019
oli-obk
approved these changes
May 26, 2019
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
May 27, 2019
rename Scalar::Bits to Scalar::Raw and bits field to data Also use this opportunity to seal some abstraction leaks (other modules constructing `Scalar::Bits` directly instead of using a constructor). r? @oli-obk
|
☀️ Try build successful - checks-travis |
|
@rust-timer build f3c7924 |
|
Success: Queued f3c7924 with parent ab7cf71, comparison URL. |
|
Finished benchmarking try commit f3c7924: comparison url |
|
This looks good perf-wise! |
|
@bors r=oli-obk |
|
📌 Commit fe19ed8 has been approved by |
|
This is on the critical path to make Miri work again. @bors p=1 |
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 28, 2019
rename Scalar::Bits to Scalar::Raw and bits field to data Also use this opportunity to seal some abstraction leaks (other modules constructing `Scalar::Bits` directly instead of using a constructor). r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 28, 2019
rename Scalar::Bits to Scalar::Raw and bits field to data Also use this opportunity to seal some abstraction leaks (other modules constructing `Scalar::Bits` directly instead of using a constructor). r? @oli-obk
bors
added a commit
that referenced
this pull request
May 28, 2019
Rollup of 4 pull requests Successful merges: - #61123 (Allow to specify profiling data output directory as -Zself-profile argument.) - #61159 (split core::ptr module into multiple files) - #61164 (rename Scalar::Bits to Scalar::Raw and bits field to data) - #61250 (Remove special case for *ios* builds in run-make-fulldeps/print-target-list Makefile) Failed merges: r? @ghost
matthiaskrgr
added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
May 28, 2019
(which is included in rust-lang/rust#61274)
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
May 28, 2019
rustup rust-lang/rust#61164 (which is included in rust-lang/rust#61274) changelog: none
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
May 28, 2019
rustup rust-lang/rust#61164 (which is included in rust-lang/rust#61274) changelog: none
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 30, 2019
Changes: ```` Rustup to rust-lang#61203 rustup rust-lang#60928 rustup rust-lang#61164 (which is included in rust-lang#61274) ````
bors
added a commit
that referenced
this pull request
May 31, 2019
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Changes: ```` Rustup to rust-lang/rust#61203 rustup rust-lang/rust#60928 rustup rust-lang/rust#61164 (which is included in rust-lang/rust#61274) ````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use this opportunity to seal some abstraction leaks (other modules constructing
Scalar::Bitsdirectly instead of using a constructor).r? @oli-obk