Skip to content

Use ? in some macros #58697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2019
Merged

Use ? in some macros #58697

merged 1 commit into from
Feb 25, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 24, 2019

No description provided.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2019
@Centril
Copy link
Contributor

Centril commented Feb 24, 2019

r? @Centril

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 24, 2019

📌 Commit 871910a has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 25, 2019
@Centril
Rollup merge of rust-lang#58697 - taiki-e:question-in-macros, r=Centril
b5cf4ea 
Use ? in some macros
@Centril Centril mentioned this pull request Feb 25, 2019
Merged
bors added a commit that referenced this pull request Feb 25, 2019
@bors
Auto merge of #58714 - Centril:rollup, r=Centril
c1911ba 
Rollup of 5 pull requests

Successful merges:

 - #58370 (Relax some Hash bounds on HashMap<K, V, S> and HashSet<T, S>)
 - #58421 (Relax some Ord bounds on BinaryHeap<T>)
 - #58686 (replace deprecated rustfmt_skip with rustfmt::skip)
 - #58697 (Use ? in some macros)
 - #58704 (Remove some unnecessary 'extern crate')

Failed merges:

r? @ghost
@bors bors merged commit 871910a into rust-lang:master Feb 25, 2019
@taiki-e taiki-e deleted the question-in-macros branch February 25, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taiki-e @rust-highfive @Centril @bors @alexcrichton