Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 22, 2019

5 commits in b33ce7fc9092962b0657b4c25354984b5e5c47e4..5c6aa46e6f28661270979696e7b4c2f0dff8628f
2019-02-19 18:42:50 +0000 to 2019-02-22 19:32:35 +0000

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2019
@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@ehuss
Copy link
Contributor Author

ehuss commented Feb 22, 2019

Unblocks #57882. cc @euclio

@alexcrichton
Copy link
Member

@bors: r+ p=1

(higher priority for unblocking something)

@bors
Copy link
Collaborator

bors commented Feb 22, 2019

📌 Commit d5484cf has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2019
@Centril
Copy link
Contributor

Centril commented Feb 23, 2019

Adjusting relative to other PRs, @bors p=2

(per Alex's note re. unblocking)

@bors
Copy link
Collaborator

bors commented Feb 23, 2019

⌛ Testing commit d5484cf with merge 02a4e27...

bors added a commit that referenced this pull request Feb 23, 2019
Update cargo

5 commits in b33ce7fc9092962b0657b4c25354984b5e5c47e4..5c6aa46e6f28661270979696e7b4c2f0dff8628f
2019-02-19 18:42:50 +0000 to 2019-02-22 19:32:35 +0000
- convert unused doc comments to regular comments (rust-lang/cargo#6692)
- Add more about system library on whether to keep Cargo.lock (rust-lang/cargo#6685)
- Warn when excluding non-existing packages (rust-lang/cargo#6679)
- Incremental profile cleanup. (rust-lang/cargo#6688)
- Various cosmetic improvements (rust-lang/cargo#6687)
@bors
Copy link
Collaborator

bors commented Feb 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 02a4e27 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 23, 2019
@bors
Copy link
Collaborator

bors commented Feb 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 02a4e27 to master...

@bors bors merged commit d5484cf into rust-lang:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants