Skip to content

remove outdated comment #57290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2019
Merged

remove outdated comment #57290

merged 1 commit into from
Jan 7, 2019

Conversation

mark-i-m
Copy link
Contributor

@mark-i-m mark-i-m commented Jan 2, 2019

#44234 was closed, apparently solved by #45353

r? @michaelwoerister

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2019
@michaelwoerister
Copy link
Member

LGTM.
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 7, 2019

📌 Commit 63b17d1 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jan 7, 2019
@pietroalbini
Rollup merge of rust-lang#57290 - mark-i-m:remove-outdated-comment, r…
c89b07a 
…=michaelwoerister

remove outdated comment

rust-lang#44234 was closed, apparently solved by rust-lang#45353

r? @michaelwoerister
@pietroalbini pietroalbini mentioned this pull request Jan 7, 2019
Merged
bors added a commit that referenced this pull request Jan 7, 2019
@bors
Auto merge of #57405 - pietroalbini:rollup, r=pietroalbini
59e70f2 
Rollup of 6 pull requests

Successful merges:

 - #57290 (remove outdated comment)
 - #57308 (Make CompileController thread-safe)
 - #57358 (use utf-8 throughout htmldocck)
 - #57369 (Provide the option to use libc++ even on all platforms)
 - #57375 (Add duration constants)
 - #57403 (Make extern ref HTTPS)

Failed merges:

 - #57370 (Support passing cflags/cxxflags/ldflags to LLVM build)

r? @ghost
@bors bors merged commit 63b17d1 into rust-lang:master Jan 7, 2019
@mark-i-m mark-i-m deleted the remove-outdated-comment branch May 25, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mark-i-m @michaelwoerister @bors @rust-highfive