beta: only true stage0 needs feature(global_allocator) #52709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `#[global_allocator]` for `stage0` builds of libstd, and also with `feature = "force_alloc_system"` that's set for a local rebuild, where the bootstrap compiler is the same version and otherwise uses the `--cfg stage1`. We only need the unstable `feature(global_allocator)` for a true `stage0` being 1.27. For rebuilds with 1.28, that feature is stable and causes a denied warning if it's enabled, so we should avoid it.
|
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
Note that the master branch has removed this feature line altogether, so this patch is only needed on beta. |
|
@bors: r+ |
|
📌 Commit b0f15d3 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 99, this pull request will be tested once the tree is reopened |
|
@bors p=1 |
kennytm
added a commit
to pietroalbini/rust
that referenced
this pull request
Jul 25, 2018
…excrichton beta: only true stage0 needs feature(global_allocator) We use `#[global_allocator]` for `stage0` builds of libstd, and also with `feature = "force_alloc_system"` that's set for a local rebuild, where the bootstrap compiler is the same version and otherwise uses the `--cfg stage1`. We only need the unstable `feature(global_allocator)` for a true `stage0` being 1.27. For rebuilds with 1.28, that feature is stable and causes a denied warning if it's enabled, so we should avoid it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
#[global_allocator]forstage0builds of libstd, and alsowith
feature = "force_alloc_system"that's set for a local rebuild,where the bootstrap compiler is the same version and otherwise uses the
--cfg stage1.We only need the unstable
feature(global_allocator)for a truestage0being 1.27. For rebuilds with 1.28, that feature is stable and causes a
denied warning if it's enabled, so we should avoid it.