Skip to content

Conversation

ollie27
Copy link
Contributor

@ollie27 ollie27 commented Feb 10, 2018

  • core_float_bits, duration_core, path_component_asref, and repr_align were stabalized in 1.25.0 not 1.24.0.
  • Impls for NonNull involving unstable things should remain unstable.
  • Duration should remain stable since 1.3.0 so it appears correctly in the std docs.
  • cursor_mut_vec is an impl on only stable things so should be marked stable.

@rust-highfive
Copy link
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 10, 2018

📌 Commit 45d5a42 has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 10, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 12, 2018
…rect a few stability attributes CODE_OF_CONDUCT.md CONTRIBUTING.md COPYRIGHT LICENSE-APACHE LICENSE-MIT README.md RELEASES.md appveyor.yml config.toml.example configure src x.py `core_float_bits`, `duration_core`, `path_component_asref`, and `repr_align` were stabalized in 1.25.0 not 1.24.0. CODE_OF_CONDUCT.md CONTRIBUTING.md COPYRIGHT LICENSE-APACHE LICENSE-MIT README.md RELEASES.md appveyor.yml config.toml.example configure src x.py Impls for `NonNull` involving unstable things should remain unstable. CODE_OF_CONDUCT.md CONTRIBUTING.md COPYRIGHT LICENSE-APACHE LICENSE-MIT README.md RELEASES.md appveyor.yml config.toml.example configure src x.py `Duration` should remain stable since 1.3.0 so it appears correctly in the `std` docs. CODE_OF_CONDUCT.md CONTRIBUTING.md COPYRIGHT LICENSE-APACHE LICENSE-MIT README.md RELEASES.md appveyor.yml config.toml.example configure src x.py `cursor_mut_vec` is an impl on only stable things so should be marked stable.
bors added a commit that referenced this pull request Feb 12, 2018
Rollup of 8 pull requests

- Successful merges: #47846, #48033, #48087, #48114, #48126, #48130, #48133, #48151
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 13, 2018
Correct a few stability attributes

* `core_float_bits`, `duration_core`, `path_component_asref`, and `repr_align` were stabalized in 1.25.0 not 1.24.0.
* Impls for `NonNull` involving unstable things should remain unstable.
* `Duration` should remain stable since 1.3.0 so it appears correctly in the `std` docs.
* `cursor_mut_vec` is an impl on only stable things so should be marked stable.
bors added a commit that referenced this pull request Feb 13, 2018
Rollup of 14 pull requests

- Successful merges: #47784, #47846, #48033, #48083, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48163, #48165, #48167
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 14, 2018
Correct a few stability attributes

* `core_float_bits`, `duration_core`, `path_component_asref`, and `repr_align` were stabalized in 1.25.0 not 1.24.0.
* Impls for `NonNull` involving unstable things should remain unstable.
* `Duration` should remain stable since 1.3.0 so it appears correctly in the `std` docs.
* `cursor_mut_vec` is an impl on only stable things so should be marked stable.
bors added a commit that referenced this pull request Feb 14, 2018
bors added a commit that referenced this pull request Feb 15, 2018
bors added a commit that referenced this pull request Feb 15, 2018
@bors
Copy link
Collaborator

bors commented Feb 15, 2018

☔ The latest upstream changes (presumably #48203) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2018
@kennytm kennytm merged commit 45d5a42 into rust-lang:master Feb 15, 2018
@ollie27 ollie27 deleted the stab branch February 15, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants