Skip to content

[beta] Use time crate in bootstrap dist instead of date #48118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[beta] Use time crate in bootstrap dist instead of date #48118

wants to merge 2 commits into from

Conversation

onur
Copy link
Contributor

@onur onur commented Feb 10, 2018

Beta backport of #48013

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2018
@pietroalbini
Copy link
Member

The bot failed to assign a reviewer... @alexcrichton?

@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Collaborator

bors commented Feb 10, 2018

📌 Commit 0895099 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2018
@kennytm
Copy link
Member

kennytm commented Feb 10, 2018

@bors p=20

@bors
Copy link
Collaborator

bors commented Feb 10, 2018

⌛ Testing commit 0895099 with merge fa56e087a5e971f9372d5023e91abeb2be91080c...

@bors
Copy link
Collaborator

bors commented Feb 10, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2018
@kennytm
Copy link
Member

kennytm commented Feb 10, 2018 •
edited
Loading

Heh, no space left on device?

�[0Ktravis_time:start:stage0-fabricate
�[0KBuilding stage0 tool fabricate (x86_64-unknown-linux-gnu)
[01:15:43] �[m�[m�[32m�[1m   Compiling�[m same-file v0.1.3
[01:15:43] �[m�[m�[32m�[1m   Compiling�[m yaml-rust v0.3.5
[01:15:43] �[m�[m�[32m�[1m   Compiling�[m pkg-config v0.3.9
[01:15:43] �[m�[m�[32m�[1m   Compiling�[m miniz-sys v0.1.10
[01:15:44] �[m�[m�[32m�[1m   Compiling�[m filetime v0.1.14
[01:15:44] �[m�[m�[32m�[1m   Compiling�[m xattr v0.1.11
[01:15:45] �[m�[m�[32m�[1m   Compiling�[m walkdir v1.0.7
[01:15:51] �[m�[m�[32m�[1m   Compiling�[m tar v0.4.14
[01:15:51] �[m�[m�[32m�[1m   Compiling�[m lzma-sys v0.1.9
[01:15:51] �[m�[m�[32m�[1m   Compiling�[m clap v2.29.0
[01:15:51] �[m�[m�[32m�[1m   Compiling�[m flate2 v1.0.1
[01:16:24] �[m�[m�[32m�[1m   Compiling�[m xz2 v0.1.3
[01:17:06] �[m�[m�[32m�[1m   Compiling�[m installer v0.0.0 (file:///checkout/src/tools/rust-installer)
[01:17:11] �[m�[m�[32m�[1m    Finished�[m release [optimized] target(s) in 87.85 secs
[01:17:11] travis_fold:end:stage0-fabricate
�[0K
[01:17:11] travis_time:end:stage0-fabricate:start=1518291862965457303,finish=1518291951467994290,duration=88502536987
�[0K
[01:17:11] Error: failed to generate installer
[01:17:11] Caused by: failed to copy '/checkout/obj/build/tmp/dist/rust-docs-beta-x86_64-unknown-linux-musl-image/share/doc/rust/html/alloc/slice/struct.Chunks.html' to '/checkout/obj/build/tmp/dist/rust-docs-beta-x86_64-unknown-linux-musl/rust-docs/share/doc/rust/html/alloc/slice/struct.Chunks.html'
[01:17:11] Caused by: No space left on device (os error 28)

The disk usage report, 14 GB used by run-pass alone

14874920	./obj/build/x86_64-unknown-linux-gnu/test/run-pass

The size of the current beta HEAD is 13 GB https://api.travis-ci.org/v3/job/336884022/log.txt, so this is sort of the last straw.

13615332	./obj/build/x86_64-unknown-linux-gnu/test/run-pass

@Mark-Simulacrum
Copy link
Member

I'm going to retry, I have a hard time believing this is actually constantly true because of this patch... @bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2018
@kennytm
Copy link
Member

kennytm commented Feb 10, 2018 •
edited
Loading

@Mark-Simulacrum The size is 10 GB six months ago, so it is likely a very old problem. We can patch compiletest to delete those generated *.err/*.out dump if the test is successful.

@Mark-Simulacrum
Copy link
Member

Well, sure, and we probably should just not keep any artifacts around on CI that aren't going to be used, but I would somewhat expect this PR not to alter whether we fail or succeed.

@bors
Copy link
Collaborator

bors commented Feb 10, 2018

⌛ Testing commit 0895099 with merge c625ea3c88b436c1fd5716ec55b289718a89fc31...

@bors
Copy link
Collaborator

bors commented Feb 10, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2018
@Mark-Simulacrum
Copy link
Member

Well, I guess it looks like we're going to have trouble landing this without some space-saving patches...

[01:07:11] travis_fold:end:stage0-fabricate
�[0K
[01:07:11] travis_time:end:stage0-fabricate:start=1518306511032822992,finish=1518306587761868217,duration=76729045225
�[0K
[01:07:12] Error: failed to generate installer
[01:07:12] Caused by: failed to write .xz
[01:07:12] Caused by: No space left on device (os error 28)
[01:07:12]

@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Feb 11, 2018
@kennytm
Copy link
Member

kennytm commented Feb 11, 2018

@onur Could you try to ignore the rustc-rust-log.rs test:

diff --git a/src/test/run-pass/rustc-rust-log.rs b/src/test/run-pass/rustc-rust-log.rs
index 629387d4cb..a0e04beaa9 100644
--- a/src/test/run-pass/rustc-rust-log.rs
+++ b/src/test/run-pass/rustc-rust-log.rs
@@ -9,5 +9,6 @@
 // except according to those terms.
 
 // rustc-env:RUST_LOG=debug
+// ignore-musl - workaround to avoid consuming all CI storage, see #48118

I bet 90% of the space usage comes from this test.

@onur
Copy link
Contributor Author

onur commented Feb 11, 2018

Done @kennytm

@kennytm
Copy link
Member

kennytm commented Feb 11, 2018

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Feb 11, 2018

📌 Commit 309e0d6 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2018
@bors
Copy link
Collaborator

bors commented Feb 11, 2018

⌛ Testing commit 309e0d6 with merge fc74e576a09f533d7a49072eec9e744a13a92e95...

@bors
Copy link
Collaborator

bors commented Feb 11, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2018
@kennytm
Copy link
Member

kennytm commented Feb 11, 2018

Guess we're wrong, run-pass is still consuming 14 GB storage 😞

@kennytm kennytm mentioned this pull request Feb 11, 2018
Merged
@Mark-Simulacrum
Copy link
Member

going to close this in favor of the general beta backport PR (#48146)

bors added a commit that referenced this pull request Feb 12, 2018
@bors
Auto merge of #48144 - kennytm:reduce-musl-test-size, r=Mark-Simulacrum
b54f27b 
Compiletest: delete the compiled program once its test is done.

Reduces CI disk usage which prevents #48118 from succeeding.
@onur onur deleted the backport-48013 branch March 2, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@onur @pietroalbini @alexcrichton @bors @kennytm @Mark-Simulacrum