Skip to content

update let-expressions hash test to use except #45987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2017
Merged

update let-expressions hash test to use except #45987

merged 1 commit into from
Nov 21, 2017

Conversation

gaurikholkar-zz
Copy link

@gaurikholkar-zz gaurikholkar-zz commented Nov 14, 2017 •
edited
Loading

A part of #44924, this PR updated let-expressions test using except.

cc @michaelwoerister
r? @nikomatsakis

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2017
@shepmaster
Copy link
Member

r? @nikomatsakis

@michaelwoerister
Copy link
Member

Thanks @gaurikholkar!

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 21, 2017

📌 Commit ef275d1 has been approved by michaelwoerister

@michaelwoerister
Copy link
Member

@bors rollup

@kennytm kennytm mentioned this pull request Nov 21, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Nov 21, 2017
@kennytm
Rollup merge of rust-lang#45987 - gaurikholkar:let-expr, r=michaelwoe…
c0c3cc4 
…rister

update let-expressions hash test to use `except`

A part of rust-lang#44924, this PR updated let-expressions test using `except`.

cc @michaelwoerister
r? @nikomatsakis
@kennytm kennytm mentioned this pull request Nov 21, 2017
Merged
bors added a commit that referenced this pull request Nov 21, 2017
@bors
Auto merge of #46166 - kennytm:rollup, r=kennytm
63739ab 
Rollup of 11 pull requests

- Successful merges: #45987, #46031, #46050, #46052, #46103, #46120, #46134, #46141, #46148, #46155, #46157
- Failed merges:
@bors bors merged commit ef275d1 into rust-lang:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gaurikholkar-zz @shepmaster @michaelwoerister @bors @kennytm @nikomatsakis @gaurikholkar