Skip to content

Conversation

emberian
Copy link
Contributor

@emberian emberian commented Dec 3, 2014

First half of bootstrapping rust-lang/rfcs#446

@alexcrichton
Copy link
Member

Before we push too hard on a new language feature like this, @cmr could you add a more extensive suite of regression tests? I'd be curious to see what happens for cases like:

  • a string with multiple escape sequences
  • a string like \\{20} where the initial backslash is escaped
  • a string with a non-matching brace
  • an escape sequence for a surrogate hex specifier
  • an escape for a too-large hex specifier
  • an escape which isn't hex

@emberian
Copy link
Contributor Author

emberian commented Dec 3, 2014

@alexcrichton all excellent testcases, I'll add these.

@alexcrichton
Copy link
Member

Thanks @cmr! Forgot to say, but r=me with those added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants