Miri subtree update #140664

RalfJung · 2025-05-05T13:59:46Z

r? @ghost

move EnvVars::cleanup into the main-thread-exit handler

Make thread scheduling fully random

…tests

add -Zmiri-deterministic-concurrency flag and use it for concurrency tests

Automatic Rustup

TB: add `Cell` state to support more fine-grained tracking of interior mutable data

add ./miri squash

…ctional). - Add a cargo feature to enable GenMC support (off by default) - Add support for GenMC datastructures to MiriMachine - Adjust several functions where GenMC needs to be informed about relevant events (e.g., atomic accesses) - Add skeleton code for parsing GenMC command line arguments - Some cleanup - Finish sentences with a `.` - Fix some spelling errors/typos Co-authored-by: Ralf Jung <post@ralfj.de>

GenMC implementation initial changes

Previously, the pointee type would be behind a `*const` pointer, so `ty_is_freeze` would always be `true`, even if there was an `UnsafeCell` in `Box`.

Automatic Rustup

…s-unique Remove -Zunique-is-unique

…e-box Tree Borrows: Correctly handle interior mutable data in `Box`

…more aggressively

move tests that are identical between SB and TB to shared files

alloc_addresses: when we are running out of addresses, start reusing more aggressively

rustbot · 2025-05-05T13:59:51Z

The Miri subtree was changed

cc @rust-lang/miri

RalfJung · 2025-05-05T14:00:51Z

@bors r+ p=1

bors · 2025-05-05T14:00:54Z

📌 Commit 4b8f88b has been approved by RalfJung

It is now in the queue for this repository.

bors · 2025-05-05T19:14:46Z

⌛ Testing commit 4b8f88b with merge 2e6882a...

bors · 2025-05-05T22:23:02Z

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 2e6882a to master...

github-actions · 2025-05-05T22:25:13Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0f73f0f (parent) -> 2e6882a (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2e6882ac5be27a73293d6f7ae56397fdf32848de --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 5546.5s -> 7676.3s (38.4%)
dist-powerpc64-linux: 6595.4s -> 5466.8s (-17.1%)
dist-x86_64-apple: 9796.2s -> 8612.8s (-12.1%)
dist-aarch64-apple: 6035.7s -> 5426.0s (-10.1%)
x86_64-gnu-llvm-20-3: 7369.4s -> 6648.0s (-9.8%)
aarch64-apple: 3488.1s -> 3266.3s (-6.4%)
x86_64-msvc-ext2: 6083.7s -> 5709.1s (-6.2%)
x86_64-apple-2: 1265.8s -> 1343.2s (6.1%)
dist-x86_64-netbsd: 5018.7s -> 5315.7s (5.9%)
x86_64-apple-1: 5803.6s -> 5516.2s (-5.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-05-06T01:00:11Z

Finished benchmarking commit (2e6882a): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	1

Max RSS (memory usage)

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 0.9%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.1%, -0.4%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[-1.1%, 0.9%]	14

Cycles

Results (primary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.4%, 0.5%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.0%, -0.4%]	8
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-1.0%, 0.5%]	11

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.361s -> 770.068s (-0.04%)
Artifact size: 365.46 MiB -> 365.41 MiB (-0.02%)

zetanumbers · 2025-05-14T13:14:49Z

Seems like this update introduced what seems to me a regression for my library's example in https://github.com/zetanumbers/scope-lock when running inside of interpreter. Trying to bisect this issue further.

RalfJung · 2025-05-14T14:24:10Z

Please file an issue. This PR only changes Miri, so seeing a regression outside of Miri should be impossible. If you see a regression inside Miri, it might also be Miri now finding UB that it missed before.

zetanumbers · 2025-05-15T15:52:34Z

rust-lang/miri#4321

geetanshjuneja and others added 30 commits April 29, 2025 19:38

Added random scheduling

ef58349

move EnvVars::cleanup into the main-thread-exit handler

47e111a

fix comment typos

76992ce

Merge pull request rust-lang#4302 from RalfJung/env-cleanup

63edce0

move EnvVars::cleanup into the main-thread-exit handler

Merge pull request rust-lang#4272 from geetanshjuneja/scheduling

f521fa0

Make thread scheduling fully random

add -Zmiri-deterministic-concurrency flag and use it for concurrency …

bbcc6a2

…tests

Merge pull request rust-lang#4303 from RalfJung/determinism

2260f77

add -Zmiri-deterministic-concurrency flag and use it for concurrency tests

Preparing for merge from rustc

589200e

Merge from rustc

326d775

fmt

7adaa50

Merge pull request rust-lang#4304 from rust-lang/rustup-2025-05-01

06e0293

Automatic Rustup

Add Cell state to Tree Borrows

8cc866d

Merge pull request rust-lang#4273 from yoctocell/new-cell-state

8bbea47

TB: add `Cell` state to support more fine-grained tracking of interior mutable data

add ./miri squash

e2d2c56

Merge pull request rust-lang#4305 from RalfJung/squash

a8da0fd

add ./miri squash

Merge pull request rust-lang#4291 from Patrick-6/miri-genmc-prep

0238548

GenMC implementation initial changes

Correctly handle interior mutable data in Box

8b36376

Previously, the pointee type would be behind a `*const` pointer, so `ty_is_freeze` would always be `true`, even if there was an `UnsafeCell` in `Box`.

Construct test so that it would fail for old code

45d4bb2

Preparing for merge from rustc

8a166dc

Merge from rustc

4d87349

Merge pull request rust-lang#4308 from rust-lang/rustup-2025-05-03

d313405

Automatic Rustup

Remove -Zunique-is-unique

30ecac8

Merge pull request rust-lang#4307 from JoJoDeveloping/remove-unique-i…

f8a8bbd

…s-unique Remove -Zunique-is-unique

move tests that are identical between SB and TB to shared files

3f0d24a

Merge pull request rust-lang#4306 from yoctocell/fix-unsafecell-insid…

70ef250

…e-box Tree Borrows: Correctly handle interior mutable data in `Box`

consistent folder naming: stacked-borrows -> stacked_borrows

aec861b

alloc_addresses: when we are running out of addresses, start reusing …

5c7f1d7

…more aggressively

Merge pull request rust-lang#4309 from RalfJung/both-borrows-tests

84b3142

move tests that are identical between SB and TB to shared files

Merge pull request rust-lang#4310 from RalfJung/addr-space-conservation

4b8f88b

alloc_addresses: when we are running out of addresses, start reusing more aggressively

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label May 5, 2025

bors merged commit 2e6882a into rust-lang:master May 5, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone May 5, 2025

bors mentioned this pull request May 5, 2025

Extend minicore with intrinsics and use it to replace #[rustc_intrinsic] in tests #140037

Draft

RalfJung deleted the miri-sync branch May 8, 2025 17:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Miri subtree update #140664

Miri subtree update #140664

Uh oh!

RalfJung commented May 5, 2025

Uh oh!

rustbot commented May 5, 2025

Uh oh!

RalfJung commented May 5, 2025

Uh oh!

bors commented May 5, 2025

Uh oh!

bors commented May 5, 2025

Uh oh!

bors commented May 5, 2025

Uh oh!

Uh oh!

github-actions bot commented May 5, 2025

Uh oh!

rust-timer commented May 6, 2025

Uh oh!

zetanumbers commented May 14, 2025

Uh oh!

RalfJung commented May 14, 2025

Uh oh!

zetanumbers commented May 15, 2025

Uh oh!

Uh oh!

Miri subtree update #140664

Miri subtree update #140664

Uh oh!

Conversation

RalfJung commented May 5, 2025

Uh oh!

rustbot commented May 5, 2025

Uh oh!

RalfJung commented May 5, 2025

Uh oh!

bors commented May 5, 2025

Uh oh!

bors commented May 5, 2025

Uh oh!

bors commented May 5, 2025

Uh oh!

Uh oh!

github-actions bot commented May 5, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented May 6, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

zetanumbers commented May 14, 2025

Uh oh!

RalfJung commented May 14, 2025

Uh oh!

zetanumbers commented May 15, 2025

Uh oh!

Uh oh!