Skip to content

Add amdgpu test for addrspacecasting global vars and the gpu-kernel calling convention #146148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2025
Merged

Add amdgpu test for addrspacecasting global vars and the gpu-kernel calling convention #146148

merged 2 commits into from
Sep 7, 2025

Conversation

Flakebi
Copy link
Contributor

@Flakebi Flakebi commented Sep 3, 2025 •
edited by rustbot
Loading

Add two tests that can now be added, as the amdgpu is merged.

Tracking issue: #135024

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2025

This PR modifies tests/auxiliary/minicore.rs.

cc @jieyouxu

@rustbot

This comment has been minimized.

Sign in to view
@Flakebi Flakebi mentioned this pull request Aug 19, 2025
Open
21 tasks
@Flakebi
Add test for addrspacecasting global vars
485bdaf 
Global variables are casted to the default address space works,
as the amdgpu target is now merged, a test can be added.
@Flakebi
Add amdgpu to gpu-kernel test
15c6585 
Check that the gpu-kernel calling convention translates to
`amdgpu_kernel` when compiling for the amdgpu target.
@Flakebi Flakebi force-pushed the global-addrspace-test branch from 36ddcb5 to 15c6585 Compare September 3, 2025 06:41
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 7, 2025

📌 Commit 15c6585 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2025
@bors
Copy link
Collaborator

bors commented Sep 7, 2025

⌛ Testing commit 15c6585 with merge 2371802...

@bors
Copy link
Collaborator

bors commented Sep 7, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 2371802 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 7, 2025
@bors bors merged commit 2371802 into rust-lang:master Sep 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 7, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 55b9b4d (parent) -> 2371802 (this PR)

Test differences

Show 4 test diffs

Stage 1

  • [codegen] tests/codegen-llvm/gpu-kernel-abi.rs#amdgpu: [missing] -> pass (J0)

Stage 2

  • [codegen] tests/codegen-llvm/gpu-kernel-abi.rs#amdgpu: [missing] -> pass (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 23718020b12d7e5a54f82a19910e8356ee719667 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3608.8s -> 4827.5s (33.8%)
  2. dist-x86_64-apple: 6915.3s -> 8473.4s (22.5%)
  3. x86_64-gnu-miri: 5702.3s -> 4463.1s (-21.7%)
  4. aarch64-gnu-llvm-19-1: 3240.1s -> 3729.1s (15.1%)
  5. dist-aarch64-apple: 5646.4s -> 6302.3s (11.6%)
  6. aarch64-msvc-1: 7097.9s -> 6541.5s (-7.8%)
  7. i686-msvc-2: 7625.9s -> 8116.7s (6.4%)
  8. aarch64-apple: 5377.9s -> 5037.3s (-6.3%)
  9. x86_64-gnu-tools: 3514.2s -> 3300.2s (-6.1%)
  10. i686-gnu-1: 7811.6s -> 7348.7s (-5.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2371802): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.4% [1.4%, 1.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.905s -> 467.642s (0.37%)
Artifact size: 387.45 MiB -> 387.46 MiB (0.00%)

@Flakebi Flakebi deleted the global-addrspace-test branch September 8, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Flakebi @rustbot @Mark-Simulacrum @bors @rust-timer